Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid dependency on org.graalvm.collections #11107

Merged
merged 1 commit into from
Sep 17, 2024
Merged

Conversation

JaroslavTulach
Copy link
Member

@JaroslavTulach JaroslavTulach commented Sep 17, 2024

Pull Request Description

I am trying to compile Enso with GraalVM 24.2.0 snapshot to verify that oracle/graal#8266 changes would work for Enso. Among the problems I am facing is a dependency on org.graalvm.collections because of using Pair. I don't think we need such dependency. Let's avoid it by using our own record with two components.

Checklist

Please ensure that the following checklist has been satisfied before submitting the PR:

  • All code follows the
    Java,
  • Unit tests continue to execute

@JaroslavTulach JaroslavTulach added CI: Ready to merge This PR is eligible for automatic merge CI: No changelog needed Do not require a changelog entry for this PR. labels Sep 17, 2024
@JaroslavTulach JaroslavTulach self-assigned this Sep 17, 2024
Copy link
Contributor

@hubertp hubertp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So what if we really decide to use Graal's collections? What's the actual problem?

@mergify mergify bot merged commit f2a809c into develop Sep 17, 2024
40 checks passed
@mergify mergify bot deleted the wip/jtulach/NoPair branch September 17, 2024 11:25
@JaroslavTulach
Copy link
Member Author

So what if we really decide to use Graal's collections? What's the actual problem?

The problem is in heavy weight dependencies. Less dependencies, the better. But of course, if we want EconomicMap for a real reason, we can use it.

@enso-bot
Copy link

enso-bot bot commented Sep 18, 2024

Jaroslav Tulach reports a new STANDUP for yesterday (2024-09-17):

Progress: .

Next Day: Traveling to Zurich for GraalVM meetup

Discord
Discord is great for playing games and chilling with friends, or even building a worldwide community. Customize your own space to talk, play, and hang out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI: No changelog needed Do not require a changelog entry for this PR. CI: Ready to merge This PR is eligible for automatic merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants