More info when critical failure occurs #11092
Conversation
Log problematic module to help with debugging critical failure.
hubertp
added
the
CI: No changelog needed
hubertp
requested review from
farmaazon,
kazcw,
vitvakatu,
Frizi,
JaroslavTulach and
AdRiley
as code owners
lib/rust/parser/generate-java/java/org/enso/syntax2/Parser.java
Outdated
Show resolved
Hide resolved
`GeneratedFormatTests.java` not `GeneratedFormatTests..java`
`./run java-gen test --skip-version-check` now works. At least locally.
JaroslavTulach
dismissed
their stale review
Logging is used. Be careful asking for features: Alas now the parser has dependency on slf4j...
|
There are still some CI failures. |
Running java tests requires us knowing all additional dependencies as they have to be added to the classpath manually. That can only be ensured by invoking the right sbt target.
Co-authored-by: Kaz Wesley <[email protected]>
|
Hubert Plociniczak reports a new STANDUP for the provided date (2024-09-19): Progress: Struggling with CI rust setup for #11092 (it requires tweaks to java classpath). Still debugging stability issues. Reduced work hours. It should be finished by 2024-09-19. Next Day: Next day I will be working on the #11092 task. Continue investigating issues. |
| return Tree.deserialize(message); | ||
| } catch (BufferUnderflowException | IllegalArgumentException e) { | ||
| LoggerFactory.getLogger(this.getClass()) | ||
| .error("Unrecoverable parser failure for: {}", input, e); |
There was a problem hiding this comment.
This code is calling error(Object,Throwable) method. What's its behavior in Enso?
When running runtime-integration-tests
Will it print the message as well as exception to the (CI) console?
When running in enso CLI mode
Will it print the message as well as exception to the (CI) console? Will it do something different?
When running in Enso IDE mode
What will appear in console and what will appear in associated log file?
There was a problem hiding this comment.
This PR changes nothing when it comes to how log messages are consumed, this is calling a plain slf4j api. The actual printing is dependent on the implementation/configuration, as you know.
If you don't like the format/output of the logger in CLI or tests then please create a ticket for that. IDE works as expected.
There was a problem hiding this comment.
If you don't like the format/output of the logger in CLI or tests then please create a ticket for that. IDE works as expected.
Which is?
What will appear in console and what will appear in associated log file?
Will you, please, answer my question?
* More info when critical failure occurs Log problematic module to help with debugging critical failure. * One more exception * s/System.err/Logger.error/ * maybe append slf4j deps * fix what looks like a long standing typo `GeneratedFormatTests.java` not `GeneratedFormatTests..java` * one more typo * Fix directory where to look for classpath `./run java-gen test --skip-version-check` now works. At least locally. * Local is fine, CI is not. More temporary debugging... * Ensure project's managedClasspath is exported Running java tests requires us knowing all additional dependencies as they have to be added to the classpath manually. That can only be ensured by invoking the right sbt target. * Move sbt call after graalvm setup * removing CI debugging * Apply suggestions from code review Co-authored-by: Kaz Wesley <[email protected]> --------- Co-authored-by: Kaz Wesley <[email protected]> (cherry picked from commit 7c41329)
Pull Request Description
Log problematic module to help with debugging critical failure.
Right now it's a real guess-work.
Related to #11088.