Fix file associations on Windows + opening project bug #11030
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
farmaazon
added
--bug
farmaazon
requested review from
PabloBuchu,
indiv0,
somebody1234 and
MrFlashAccount
as code owners
|
Working on MacOS:
Although I might note a small detail: it is impossible to open multiple projects simultaneously when clicking files in Finder – the latest project always takes precedence and the previous one will be closed. It is the issue on develop as well, though, so not to block this PR. |
|
@vitvakatu i think being able to only open a single project is intentional, but tbh I'm not 100% sure it is intended behavior for the local backend. @jdunkerley can you confirm or deny? |
|
Yes currently we only support opening one project at a time. We will improve that later. |
MrFlashAccount
approved these changes
Sep 11, 2024
jdunkerley
pushed a commit
that referenced
this pull request
Sep 11, 2024
* Fixes [#10983](#10983) The `ext` field was not set according to the documentation in rust * Also discovered a regression in opening project by passing argument/clicking the file: we store the file location as `file://` URL, but without caution, it made a havoc with windows paths. # Important Notes - [x] **Need to confirm that everything works on macOS** (installation with file associations + opening project when process is running and when not) (cherry picked from commit 497da82)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
extfield was not set according to the documentation in rustfile://URL, but without caution, it made a havoc with windows paths.Important Notes
Checklist
Please ensure that the following checklist has been satisfied before submitting the PR:
[ ] Screenshots/screencasts have been attached, if there are any visual changes. For interactive or animated visual changes, a screencast is preferred.Scala,
Java,
TypeScript,
and
Rust
style guides. In case you are using a language not listed above, follow the Rust style guide.
[ ] Unit tests have been written where possible.