Prevent node name collisions when drag-and-dropping multiple files #10979
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Frizi
requested review from
PabloBuchu,
indiv0,
somebody1234,
MrFlashAccount,
farmaazon,
vitvakatu,
kazcw and
AdRiley
as code owners
somebody1234
approved these changes
Sep 4, 2024
kazcw
approved these changes
Sep 4, 2024
vitvakatu
reviewed
Sep 4, 2024
| delayedNodesToCreate.push(options) | ||
| // Delay node creation to next tick, batch multiple synchronous createNode calls together | ||
| // to avoid node name collisions. | ||
| if (delayedNodesToCreate.length === 1) { |
There was a problem hiding this comment.
A strict === 1 comparison seems suspicious, why not >= 1? It kinda contradicts the comment which says batch multiple … calls together
There was a problem hiding this comment.
It schedules a flush operation when the queue transitions from empty to non-empty. If the queue is already non-empty (i.e. after adding an element, the queue's new length is 2 or more), a flush has already been scheduled.
somebody1234
pushed a commit
that referenced
this pull request
Sep 8, 2024
…10979) # Important Notes Fixed a few warnings in dashboard caused by missing or misplaced key attributes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10961
Important Notes
Fixed a few warnings in dashboard caused by missing or misplaced key attributes.
Checklist
Please ensure that the following checklist has been satisfied before submitting the PR:
Scala,
Java,
TypeScript,
and
Rust
style guides. In case you are using a language not listed above, follow the Rust style guide.