Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Couple of small fixes for vizzes. #10963

Merged
merged 6 commits into from
Sep 3, 2024
Merged

Couple of small fixes for vizzes. #10963

merged 6 commits into from
Sep 3, 2024

Conversation

jdunkerley
Copy link
Member

@jdunkerley jdunkerley commented Sep 3, 2024 •
edited
Loading

Pull Request Description

  • Improve logic for white space rendering (render leading/trailing in partial, change the tab rendering).
  • Escape HTML characters.
  • Fix for the geo viz starting zoom and center.

image

image

image

Checklist

Please ensure that the following checklist has been satisfied before submitting the PR:

  • The documentation has been updated, if necessary.
  • Screenshots/screencasts have been attached, if there are any visual changes. For interactive or animated visual changes, a screencast is preferred.
  • All code follows the
    Scala,
    Java,
    TypeScript,
    and
    Rust
    style guides. In case you are using a language not listed above, follow the Rust style guide.
  • Unit tests have been written where possible.

@jdunkerley jdunkerley added the CI: No changelog needed Do not require a changelog entry for this PR. label Sep 3, 2024
@jdunkerley jdunkerley marked this pull request as ready for review September 3, 2024 14:15
@jdunkerley jdunkerley added the CI: Ready to merge This PR is eligible for automatic merge label Sep 3, 2024
@mergify mergify bot merged commit 26678f3 into develop Sep 3, 2024
36 checks passed
@mergify mergify bot deleted the wip/jd/table-fixes branch September 3, 2024 20:17
@jdunkerley jdunkerley mentioned this pull request Sep 3, 2024
Open
jdunkerley added a commit that referenced this pull request Sep 9, 2024
@jdunkerley
Couple of small fixes for vizzes. (#10963)
babddd7 
- Improve logic for white space rendering (render leading/trailing in partial, change the tab rendering).
- Escape HTML characters.
- Fix for the geo viz starting zoom and center.

![image](https://github.com/user-attachments/assets/ac8c8893-14b5-4242-ba82-b821797546a1)

![image](https://github.com/user-attachments/assets/a179b4ad-d295-4783-97d9-803b6958cb95)

![image](https://github.com/user-attachments/assets/e4be7a81-28ff-4e79-b6e0-9aadae059270)

(cherry picked from commit 26678f3)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kazcw kazcw kazcw approved these changes

@marthasharkey marthasharkey marthasharkey approved these changes

@GregoryTravis GregoryTravis GregoryTravis approved these changes

@Frizi Frizi Awaiting requested review from Frizi Frizi is a code owner

@farmaazon farmaazon Awaiting requested review from farmaazon farmaazon is a code owner

@vitvakatu vitvakatu Awaiting requested review from vitvakatu vitvakatu is a code owner

@AdRiley AdRiley Awaiting requested review from AdRiley AdRiley is a code owner

Assignees
No one assigned
Labels
CI: No changelog needed Do not require a changelog entry for this PR. CI: Ready to merge This PR is eligible for automatic merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jdunkerley @kazcw @GregoryTravis @marthasharkey