Dashboard improvements 08/26/2024 #10946

somebody1234 · 2024-09-02T10:07:18Z

Pull Request Description

Address part of https://github.com/enso-org/cloud-v2/issues/1453
- Many of the other issues are addressed in other PRs.
- Username in "Set username" dialog defaults to user email
- Hide "Share with" column for Free and Solo plans
- Reorder categories in left sidebar
  - Previous: Cloud, My Files, Recent, Trash, ...Users, ...Teams
  - New: Cloud, Me (formerly My Files), ...Users, Teams, Recent, Trash
Fix In the local projects list, columns can be removed but cannot be re-added #10968
- Show column toggles on Local category too (previously was explicitly specialcased to only be visible on Cloud categories as a remnant of the old design with the backend switcher at the top)
  - Added to this PR as this PR already touches the column toggles

Important Notes

None

Checklist

Please ensure that the following checklist has been satisfied before submitting the PR:

~~The documentation has been updated, if necessary.~~
Screenshots/screencasts have been attached, if there are any visual changes. For interactive or animated visual changes, a screencast is preferred.
All code follows the
Scala,
Java,
TypeScript,
and
Rust
style guides. In case you are using a language not listed above, follow the Rust style guide.
~~Unit tests have been written where possible.~~

PabloBuchu · 2024-09-03T09:23:34Z

Set organization name modal is still not being dismissed after submit. Is this fixed somewhere else?
Lets hide share with also for team (sorry if I wasnt clear). The column only makes sense for enterprise. Lets hide it behind devtools
Trash still has Users and Teams. Is this fixed somewhere else?
Same for asset panel. Should I qa it somewhere else?
striping @domain.com is intentional in username? Lets make it to be == with email

somebody1234 · 2024-09-03T09:44:05Z

2, 3, 5: will do.

for 3... i think maybe this should be fixed on the BE side? might need further discussion

somebody1234 · 2024-09-03T12:04:19Z

2, 5 fixed, as mentioned above i'm not sure about 3. maybe it should be fixed separately.

PabloBuchu · 2024-09-03T12:45:33Z

ok lets discuss trash on channel ✅

MrFlashAccount · 2024-09-06T08:34:29Z

app/dashboard/src/utilities/LocalStorage.ts

@@ -74,9 +76,28 @@ export default class LocalStorage {

  /** Register runtime behavior associated with a {@link LocalStorageKey}. */
  static registerKey<K extends LocalStorageKey>(key: K, metadata: LocalStorageKeyMetadata<K>) {
+    if (!IS_DEV_MODE) {
+      invariant(


this one looks... silly. I do want to know that before we deploy to prod :)

ah, good point... i was hiding it because it was (incorrectly) showing up on HMR refresh. any thoughts? i could instead have it e.g. throw and error and catch it to capture the stack trace... it's hacky but should more or less work...

Maybe we can utilize this API to avoid incorrect behavior during HMR? https://vitejs.dev/guide/api-hmr

But this might not be sufficient: we need to make sure that the key is exact the same. (the key is coming from the same module)

not sure it's an option, yeah. especially since (afaict) you'd have to pass in import.meta.hot from the module that is calling .register, which means exposing implementation details to implementors.

right now i'm pushing an implementation based on stack traces instead, let me know your thoughts i guess?

In dev mode, I'm okay with that.

FWIW, to get access to the stack trace, you can call new Error().stack instead

yeah XD i was throwing a new error and then wondering why i was catching it when i could just access its stack directly

…ocation

- Address part of enso-org/cloud-v2#1453 - Many of the other issues are addressed in other PRs. - Username in "Set username" dialog defaults to user email - Hide "Share with" column for Free and Solo plans - Reorder categories in left sidebar - Previous: Cloud, My Files, Recent, Trash, ...Users, ...Teams - New: Cloud, Me (formerly My Files), ...Users, Teams, Recent, Trash - Fix #10968 - Show column toggles on Local category too (previously was explicitly specialcased to only be visible on Cloud categories as a remnant of the old design with the backend switcher at the top) - Added to this PR as this PR already touches the column toggles None

- Address part of enso-org/cloud-v2#1453 - Many of the other issues are addressed in other PRs. - Username in "Set username" dialog defaults to user email - Hide "Share with" column for Free and Solo plans - Reorder categories in left sidebar - Previous: Cloud, My Files, Recent, Trash, ...Users, ...Teams - New: Cloud, Me (formerly My Files), ...Users, Teams, Recent, Trash - Fix #10968 - Show column toggles on Local category too (previously was explicitly specialcased to only be visible on Cloud categories as a remnant of the old design with the backend switcher at the top) - Added to this PR as this PR already touches the column toggles # Important Notes None (cherry picked from commit 3420a05)

) Closes: enso-org/cloud-v2#1473 This PR fixes a bug introduced in #10946

- Address part of enso-org/cloud-v2#1453 - Many of the other issues are addressed in other PRs. - Username in "Set username" dialog defaults to user email - Hide "Share with" column for Free and Solo plans - Reorder categories in left sidebar - Previous: Cloud, My Files, Recent, Trash, ...Users, ...Teams - New: Cloud, Me (formerly My Files), ...Users, Teams, Recent, Trash - Fix #10968 - Show column toggles on Local category too (previously was explicitly specialcased to only be visible on Cloud categories as a remnant of the old design with the backend switcher at the top) - Added to this PR as this PR already touches the column toggles # Important Notes None (cherry picked from commit 3420a05)

) Closes: enso-org/cloud-v2#1473 This PR fixes a bug introduced in #10946 (cherry picked from commit 1fdaf37)

- Address part of enso-org/cloud-v2#1453 - Many of the other issues are addressed in other PRs. - Username in "Set username" dialog defaults to user email - Hide "Share with" column for Free and Solo plans - Reorder categories in left sidebar - Previous: Cloud, My Files, Recent, Trash, ...Users, ...Teams - New: Cloud, Me (formerly My Files), ...Users, Teams, Recent, Trash - Fix #10968 - Show column toggles on Local category too (previously was explicitly specialcased to only be visible on Cloud categories as a remnant of the old design with the backend switcher at the top) - Added to this PR as this PR already touches the column toggles # Important Notes None (cherry picked from commit 3420a05)

) Closes: enso-org/cloud-v2#1473 This PR fixes a bug introduced in #10946 (cherry picked from commit 1fdaf37)

somebody1234 added 4 commits September 2, 2024 14:15

Reorder Category Switcher; rename "My Files" to "Me"

5223e78

Hide "Shared with" column for Free/Solo users

6e6c775

Default username to name of email address

b8a85b6

Add LocalStorage key metadata for Asset Panel width

21f0653

somebody1234 added CI: No changelog needed Do not require a changelog entry for this PR. g-dashboard labels Sep 2, 2024

somebody1234 requested review from PabloBuchu, indiv0, MrFlashAccount, Frizi, farmaazon, vitvakatu, kazcw and AdRiley as code owners September 2, 2024 10:07

somebody1234 added 2 commits September 3, 2024 21:55

Stop stripping domain in default username

ad6b4b7

Refactor column list; hide "shared with" column for Team plan

b4c1c80

Fix errors

98db7db

PabloBuchu approved these changes Sep 3, 2024

View reviewed changes

somebody1234 added 2 commits September 4, 2024 16:21

Show hidden columns toggle even for Local Category

827b33c

Merge branch 'develop' into wip/sb/dashboard-improvements-08-26

4309d5d

MrFlashAccount approved these changes Sep 6, 2024

View reviewed changes

Use stack trace to detect changes in LocalStorage.register source l…

c557ebc

…ocation

somebody1234 added the CI: Ready to merge This PR is eligible for automatic merge label Sep 6, 2024

Merge branch 'develop' into wip/sb/dashboard-improvements-08-26

45cc2b0

mergify bot merged commit 3420a05 into develop Sep 6, 2024
36 checks passed

mergify bot deleted the wip/sb/dashboard-improvements-08-26 branch September 6, 2024 15:13

MrFlashAccount mentioned this pull request Sep 9, 2024

Fix skipping creating a user if we don't change the default name #11013

Merged

4 tasks

mergify bot pushed a commit that referenced this pull request Sep 9, 2024

Fix skipping creating a user if we don't change the default name (#11013

1fdaf37

) Closes: enso-org/cloud-v2#1473 This PR fixes a bug introduced in #10946

jdunkerley pushed a commit that referenced this pull request Sep 10, 2024

Fix skipping creating a user if we don't change the default name (#11013

ecf95eb

) Closes: enso-org/cloud-v2#1473 This PR fixes a bug introduced in #10946 (cherry picked from commit 1fdaf37)

jdunkerley pushed a commit that referenced this pull request Sep 10, 2024

Fix skipping creating a user if we don't change the default name (#11013

3cef865

) Closes: enso-org/cloud-v2#1473 This PR fixes a bug introduced in #10946 (cherry picked from commit 1fdaf37)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Dashboard improvements 08/26/2024 #10946

Dashboard improvements 08/26/2024 #10946

somebody1234 commented Sep 2, 2024 •

edited

Loading

PabloBuchu commented Sep 3, 2024 •

edited

Loading

somebody1234 commented Sep 3, 2024 •

edited

Loading

somebody1234 commented Sep 3, 2024

PabloBuchu commented Sep 3, 2024

MrFlashAccount Sep 6, 2024

somebody1234 Sep 6, 2024

MrFlashAccount Sep 6, 2024 •

edited

Loading

somebody1234 Sep 6, 2024

MrFlashAccount Sep 6, 2024

somebody1234 Sep 6, 2024

Dashboard improvements 08/26/2024 #10946

Dashboard improvements 08/26/2024 #10946

Conversation

somebody1234 commented Sep 2, 2024 • edited Loading

Pull Request Description

Important Notes

Checklist

PabloBuchu commented Sep 3, 2024 • edited Loading

somebody1234 commented Sep 3, 2024 • edited Loading

somebody1234 commented Sep 3, 2024

PabloBuchu commented Sep 3, 2024

MrFlashAccount Sep 6, 2024

Choose a reason for hiding this comment

somebody1234 Sep 6, 2024

Choose a reason for hiding this comment

MrFlashAccount Sep 6, 2024 • edited Loading

Choose a reason for hiding this comment

somebody1234 Sep 6, 2024

Choose a reason for hiding this comment

MrFlashAccount Sep 6, 2024

Choose a reason for hiding this comment

somebody1234 Sep 6, 2024

Choose a reason for hiding this comment

somebody1234 commented Sep 2, 2024 •

edited

Loading

PabloBuchu commented Sep 3, 2024 •

edited

Loading

somebody1234 commented Sep 3, 2024 •

edited

Loading

MrFlashAccount Sep 6, 2024 •

edited

Loading