Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make tab accept the text input #10857

Merged
merged 2 commits into from
Aug 21, 2024
Merged

Conversation

farmaazon
Copy link
Contributor

Pull Request Description

Fixes #10855

Added handler for tab key. We cannot accept input on blur, as sometimes it should not be accepted (as when user clicks at drop-down option where text widget was providing filtering pattern).

Important Notes

Checklist

Please ensure that the following checklist has been satisfied before submitting the PR:

  • The documentation has been updated, if necessary.
  • [ ] Screenshots/screencasts have been attached, if there are any visual changes. For interactive or animated visual changes, a screencast is preferred.
  • All code follows the
    Scala,
    Java,
    TypeScript,
    and
    Rust
    style guides. In case you are using a language not listed above, follow the Rust style guide.
  • [ ] Unit tests have been written where possible.

@farmaazon farmaazon added --bug Type: bug -gui labels Aug 21, 2024
@farmaazon farmaazon self-assigned this Aug 21, 2024
@farmaazon farmaazon added the CI: Ready to merge This PR is eligible for automatic merge label Aug 21, 2024
@mergify mergify bot merged commit a9198c8 into develop Aug 21, 2024
37 checks passed
@mergify mergify bot deleted the wip/farmaazon/fix-tabbing-text-widget branch August 21, 2024 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
--bug Type: bug -gui CI: Ready to merge This PR is eligible for automatic merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pressing Tab in a Text Input does not accept the result
2 participants