Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dropdown improvements #10853

Merged
merged 3 commits into from
Aug 21, 2024
Merged

Dropdown improvements #10853

merged 3 commits into from
Aug 21, 2024

Conversation

kazcw
Copy link
Contributor

@kazcw kazcw commented Aug 20, 2024 •
edited
Loading

Pull Request Description

Implement changes requested in #10666.

Align left edge with widget

Top-level argument (edge aligned to TLA boundary):

Screenshot 2024-08-20 at 10 10 27

Nested (edge aligned to start of widget text):

Screenshot 2024-08-20 at 10 11 47

Adjust height

Screenshot 2024-08-20 at 10 06 20

Important Notes

  • Also some HTML/CSS simplification in CircularMenu.

Checklist

Please ensure that the following checklist has been satisfied before submitting the PR:

  • The documentation has been updated, if necessary.
  • Screenshots/screencasts have been attached, if there are any visual changes. For interactive or animated visual changes, a screencast is preferred.
  • All code follows the
    Scala,
    Java,
    TypeScript,
    and
    Rust
    style guides. In case you are using a language not listed above, follow the Rust style guide.
  • Unit tests have been written where possible.

@kazcw
Dropdown improvements
2401d5d 
- Align left edge with widget
- Fix Z-order
- Adjust height
@kazcw kazcw added the CI: No changelog needed Do not require a changelog entry for this PR. label Aug 20, 2024
@kazcw kazcw self-assigned this Aug 20, 2024
@kazcw kazcw marked this pull request as ready for review August 21, 2024 01:00
@kazcw kazcw added the CI: Ready to merge This PR is eligible for automatic merge label Aug 21, 2024
@mergify mergify bot merged commit 45a54b9 into develop Aug 21, 2024
37 checks passed
@mergify mergify bot deleted the wip/kw/dropdown branch August 21, 2024 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@farmaazon farmaazon farmaazon approved these changes

@Frizi Frizi Awaiting requested review from Frizi Frizi is a code owner

@vitvakatu vitvakatu Awaiting requested review from vitvakatu vitvakatu is a code owner

@AdRiley AdRiley Awaiting requested review from AdRiley AdRiley is a code owner

Assignees

@kazcw kazcw

Labels
CI: No changelog needed Do not require a changelog entry for this PR. CI: Ready to merge This PR is eligible for automatic merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kazcw @farmaazon