Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix date_diff in Snowflake #10672

Merged
merged 6 commits into from
Jul 25, 2024
Merged

Fix date_diff in Snowflake #10672

merged 6 commits into from
Jul 25, 2024

Conversation

radeusgd
Copy link
Member

Pull Request Description

Important Notes

Checklist

Please ensure that the following checklist has been satisfied before submitting the PR:

  • The documentation has been updated, if necessary.
  • Screenshots/screencasts have been attached, if there are any visual changes. For interactive or animated visual changes, a screencast is preferred.
  • All code follows the
    Scala,
    Java,
    TypeScript,
    and
    Rust
    style guides. In case you are using a language not listed above, follow the Rust style guide.
  • Unit tests have been written where possible.

@radeusgd radeusgd added the CI: No changelog needed Do not require a changelog entry for this PR. label Jul 25, 2024
@radeusgd radeusgd self-assigned this Jul 25, 2024
@radeusgd
Copy link
Member Author

radeusgd commented Jul 25, 2024 •
edited
Loading

The edge tests were merged back into main tests.

With the fix the tests are now passing locally for Snowflake. Also scheduled a CI run of the Snowflake suite: https://github.com/enso-org/enso/actions/runs/10094244843

Extra Nightly Tests

@radeusgd
Copy link
Member Author

I'm not 100% sure that the operations will return exactly the same results for all edge cases. But some interesting edge cases are checked in the tests and they are all aligned - so I think this is okay. We cannot really do much better relying on the DB for the computation.

@jdunkerley jdunkerley added the CI: Ready to merge This PR is eligible for automatic merge label Jul 25, 2024
@mergify mergify bot merged commit ba8ae45 into develop Jul 25, 2024
38 checks passed
@mergify mergify bot deleted the wip/radeusgd/10438-snowflake-date-diff branch July 25, 2024 16:16
jdunkerley pushed a commit that referenced this pull request Jul 26, 2024
@radeusgd @jdunkerley
Fix date_diff in Snowflake (#10672)
d1226e2 
- Closes #10438
- The results are again aligned across backends.

(cherry picked from commit ba8ae45)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdunkerley jdunkerley jdunkerley approved these changes

@GregoryTravis GregoryTravis Awaiting requested review from GregoryTravis GregoryTravis is a code owner

@AdRiley AdRiley Awaiting requested review from AdRiley AdRiley is a code owner

@marthasharkey marthasharkey Awaiting requested review from marthasharkey marthasharkey is a code owner

Assignees

@radeusgd radeusgd

Labels
CI: No changelog needed Do not require a changelog entry for this PR. CI: Ready to merge This PR is eligible for automatic merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

date_diff operation works differently on Postgres and Snowflake
2 participants
@radeusgd @jdunkerley