Stub Out the Parser Interface #1065
Conversation
# Conflicts: # build.sbt
Kesanov
requested review from
iamrecursion,
kustosz and
radeusgd
as code owners
build.sbt
Outdated
| lazy val parser = (project in file("lib/scala/parser")) | ||
| .settings( | ||
| fork := true, | ||
| javaOptions += { | ||
| val root = baseDirectory.value.getParentFile.getParentFile.getParentFile | ||
| s"-Djava.library.path=$root/target/rust/debug" | ||
| }, |
There was a problem hiding this comment.
I understand that currently no projects depend on the parser, but in the future, at least runtime will, right?
Is there a plan on how to include these binary dependencies in the distribution of runtime? Will they be packaged in some native_lib directory or inside the JAR? How should users/programs launching the runtime handle the java.library.path?
I feel like this should be documented. I guess it may be added when runtime really becomes dependent on the new parser, but I'm worried we may forget to do so then, so maybe at least a general plan on how this will happen would be good?
There was a problem hiding this comment.
This should definitely be documented now, both in the parser documentation (the why), and the distribution documentation (the what).
build.sbt
Outdated
| fork := true, | ||
| Cargo.rustVersion := rustVersion, | ||
| Compile / compile / compileInputs := (Compile / compile / compileInputs) | ||
| .dependsOn(Cargo("build -p parser")) |
There was a problem hiding this comment.
| .dependsOn(Cargo("build -p parser")) | |
| .dependsOn(Cargo("build --project parser")) |
There was a problem hiding this comment.
Looks really great! I especially like the documentation explaining the Rust infrastructure.
Still it would be cool if these few functions in the project/ directory got at least some short summaries.
Also, I'm not sure if this is in scope in this pull request, but we need to keep in mind that, at some point before starting to use the new parser, we need to:
- add the
native-librariesto the build workflows (both thescala.ymlfor CI builds andrelease.ymlfor releases) - update information on compiling the legal information regarding the licences that are used in the dependencies that we distribute.
It may be worth creating separate issues for these, I guess. What do you think @iamrecursion ?
Pull Request Description
Closes #1006
Checklist
Please include the following checklist in your PR: