Implement in-memory and database mixed decimal column comparisons #10614
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GregoryTravis
requested review from
jdunkerley,
radeusgd,
AdRiley and
marthasharkey
as code owners
|
This still has only failing test but mostly it is ready for review. |
GregoryTravis
changed the title
GregoryTravis
added
the
CI: Clean build required
jdunkerley
approved these changes
Jul 24, 2024
radeusgd
reviewed
Jul 24, 2024
Comment on lines
673
to
698
| group_builder.specify "(Column_Operations_Spec) should allow to compare numbers (including mixed types)" <| | ||
| x_values = [1.25, 4.5, 5.0] | ||
| y_values = [2.0, 3.0, 5.0] | ||
|
|
||
| converters = [.truncate, x->x, dec] | ||
| converters.map x_converter-> converters.map y_converter-> | ||
| x_values_converted = x_values.map x_converter | ||
| y_values_converted = y_values.map y_converter | ||
| with_mixed_columns_if_supported [['x', x_values_converted + [Nothing]], ['y', y_values_converted + [Nothing]]] t-> | ||
| x = t.at "x" | ||
| y = t.at "y" | ||
|
|
||
| Test.with_clue " comparison: "+x.value_type.to_text+', '+y.value_type.to_text+" " <| | ||
| (x < y).to_vector . should_equal [True, False, False, Nothing] | ||
| (x <= y).to_vector . should_equal [True, False, True, Nothing] | ||
| (x > y).to_vector . should_equal (x <= y).not.to_vector | ||
| (x >= y).to_vector . should_equal (x < y).not.to_vector | ||
|
|
||
| converters.map converter-> | ||
| const_float = 3.0 | ||
| constant = converter const_float | ||
| Test.with_clue " constant: "+(Meta.get_simple_type_name constant) <| | ||
| (x == constant).to_vector . should_equal [False, False, False, Nothing] | ||
| (x != constant).to_vector . should_equal [True, True, True, Nothing] | ||
| (y == constant).to_vector . should_equal [False, True, False, Nothing] | ||
| (y != constant).to_vector . should_equal [True, False, True, Nothing] |
There was a problem hiding this comment.
This is a lot of nesting. What is the runtime of this test for in-memory/Postgres?
I think it should be disabled for Snowflake as I imagine it will be super slow there.
Could you make it pending if run_advanced_edge_case_tests is false?
radeusgd
approved these changes
Jul 24, 2024
There was a problem hiding this comment.
Looks good, but now that we know how much slower tests like Snowflake are, please let's ensure that such thorough tests are hidden behind run_advanced_edge_case_tests flag. Apart from in-memory, they are testing the underlying DB implementation that we do not control anyway.
GregoryTravis
added
CI: Ready to merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also implement more comprehensive mixed comparison tests.
Checklist
Please ensure that the following checklist has been satisfied before submitting the PR:
Scala,
Java,
TypeScript,
and
Rust
style guides. In case you are using a language not listed above, follow the Rust style guide.