Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Snowflake Dialect pt. 6 - Union, Distinct and other improvements #10576

Merged
merged 47 commits into from
Jul 19, 2024

Conversation

radeusgd
Copy link
Member

@radeusgd radeusgd commented Jul 17, 2024

Pull Request Description

  • Part of Snowflake Dialect #9486
  • Fixes Table.union, merge and distinct tests
  • Replaces distinct_on in Context that was actually a Postgres specific addition leaking into the base with a more abstract Context_Extension mechanism.
    • This allows us to implement the Snowflake-specific DISTINCT using QUALIFY.

Important Notes

Checklist

Please ensure that the following checklist has been satisfied before submitting the PR:

  • The documentation has been updated, if necessary.
  • Screenshots/screencasts have been attached, if there are any visual changes. For interactive or animated visual changes, a screencast is preferred.
  • All code follows the
    Scala,
    Java,
    TypeScript,
    and
    Rust
    style guides. In case you are using a language not listed above, follow the Rust style guide.
  • Unit tests have been written where possible.

@radeusgd radeusgd added the CI: No changelog needed Do not require a changelog entry for this PR. label Jul 17, 2024
@radeusgd radeusgd self-assigned this Jul 17, 2024
@radeusgd radeusgd marked this pull request as ready for review July 17, 2024 15:22
@radeusgd radeusgd added the CI: Ready to merge This PR is eligible for automatic merge label Jul 18, 2024
@radeusgd radeusgd added the CI: Clean build required CI runners will be cleaned before and after this PR is built. label Jul 19, 2024
@mergify mergify bot merged commit 7fd8701 into develop Jul 19, 2024
34 of 36 checks passed
@mergify mergify bot deleted the wip/radeusgd/snowflake-dialect-6 branch July 19, 2024 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI: Clean build required CI runners will be cleaned before and after this PR is built. CI: No changelog needed Do not require a changelog entry for this PR. CI: Ready to merge This PR is eligible for automatic merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants