-
Notifications
You must be signed in to change notification settings - Fork 324
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Snowflake Dialect pt. 6 - Union, Distinct and other improvements #10576
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
radeusgd
added
the
CI: No changelog needed
Do not require a changelog entry for this PR.
label
Jul 17, 2024
radeusgd
requested review from
GregoryTravis,
AdRiley and
marthasharkey
as code owners
July 17, 2024 15:22
GregoryTravis
approved these changes
Jul 17, 2024
jdunkerley
approved these changes
Jul 18, 2024
…named and changed behavior
radeusgd
added
the
CI: Clean build required
CI runners will be cleaned before and after this PR is built.
label
Jul 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
CI: Clean build required
CI runners will be cleaned before and after this PR is built.
CI: No changelog needed
Do not require a changelog entry for this PR.
CI: Ready to merge
This PR is eligible for automatic merge
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Table.union
,merge
anddistinct
testsdistinct_on
inContext
that was actually a Postgres specific addition leaking into the base with a more abstractContext_Extension
mechanism.DISTINCT
usingQUALIFY
.Important Notes
Checklist
Please ensure that the following checklist has been satisfied before submitting the PR:
Scala,
Java,
TypeScript,
and
Rust
style guides. In case you are using a language not listed above, follow the Rust style guide.