-
Notifications
You must be signed in to change notification settings - Fork 324
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Optimize assets table #10522
Optimize assets table #10522
Conversation
Events are still being handled twice Also removing labels does not work
// =============== | ||
// === Newtype === | ||
// =============== | ||
|
||
/** An interface specifying the variant of a newtype. */ | ||
export interface NewtypeVariant<TypeName extends string> { | ||
type NewtypeVariant<TypeName extends string> = { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I assume you want to forbid the flexibility which interface gives us?
Also, the types are no longer exported; are they actually used?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
forbid the flexibility which interface gives us?
i guess technically? but it's not the main reason
the types are no longer exported; are they actually used?
only internally - this is the real reason behind this change. apparently if we don't export the interfaces
, TS complains because it cannot name them (because interface declarations are kinda sorta nominal because they can be merged into)
so basically this change is so that we no longer have to export it (and clutter up autocomplete) just so that it's visible
@somebody1234 Is there any particular thing that should be QAed or just general performance improvements? |
yeah it should be just perf improvements. specifically the only thing (other than minor CSS improvements) is a refactor of the "reactive events" that were previously being used to minimize the amount of things that need to re-render |
Pull Request Description
AssetsTable
on everyAssetEvent
zustand
for fine-grained reactivity.Other misc fixes:
Important Notes
None
Checklist
Please ensure that the following checklist has been satisfied before submitting the PR:
The documentation has been updated, if necessary.Screenshots/screencasts have been attached, if there are any visual changes. For interactive or animated visual changes, a screencast is preferred.Scala,
Java,
TypeScript,
and
Rust
style guides. In case you are using a language not listed above, follow the Rust style guide.
Unit tests have been written where possible.