Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Date Time Pickers, Temporarily Disable Encoding.default #10493

Merged
merged 5 commits into from
Jul 9, 2024

Conversation

jdunkerley
Copy link
Member

@jdunkerley jdunkerley commented Jul 9, 2024

Pull Request Description

  • Widgets for Date_Time, Time_Of_Day and Time_Zone.
  • Disable Encoding.default for now as big performance impact on CSVs.

image

image

image

image

Checklist

Please ensure that the following checklist has been satisfied before submitting the PR:

  • The documentation has been updated, if necessary.
  • Screenshots/screencasts have been attached, if there are any visual changes. For interactive or animated visual changes, a screencast is preferred.
  • All code follows the
    Scala,
    Java,
    TypeScript,
    and
    Rust
    style guides. In case you are using a language not listed above, follow the Rust style guide.
  • Unit tests have been written where possible.

@jdunkerley jdunkerley force-pushed the wip/jd/fixes-from-prepdata branch from 910cc9a to 4165ea7 Compare July 9, 2024 17:46
@jdunkerley jdunkerley changed the title Small Fixes from Preppin Data Date Time Pickers, Temporarily Disable Encoding.default Jul 9, 2024
@jdunkerley jdunkerley marked this pull request as ready for review July 9, 2024 17:47
@jdunkerley jdunkerley added the CI: No changelog needed Do not require a changelog entry for this PR. label Jul 9, 2024
@jdunkerley jdunkerley added the CI: Ready to merge This PR is eligible for automatic merge label Jul 9, 2024
@mergify mergify bot merged commit 8da0630 into develop Jul 9, 2024
37 checks passed
@mergify mergify bot deleted the wip/jd/fixes-from-prepdata branch July 9, 2024 21:04
@radeusgd radeusgd mentioned this pull request Jul 11, 2024
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI: No changelog needed Do not require a changelog entry for this PR. CI: Ready to merge This PR is eligible for automatic merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants