Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deserialise large integer and decimals from JSON automatically. #10463

Merged
merged 2 commits into from
Jul 5, 2024

Conversation

jdunkerley
Copy link
Member

@jdunkerley jdunkerley commented Jul 5, 2024

Pull Request Description

  • Sort large integer and decimal JSON deserialization.
  • Change type to be Integer instead of BigInt for large integers.
  • Add tests.
  • Update Table viz.
  • Preserve white space in JSON viz.
    image

image

Checklist

Please ensure that the following checklist has been satisfied before submitting the PR:

  • The documentation has been updated, if necessary.
  • Screenshots/screencasts have been attached, if there are any visual changes. For interactive or animated visual changes, a screencast is preferred.
  • All code follows the
    Scala,
    Java,
    TypeScript,
    and
    Rust
    style guides. In case you are using a language not listed above, follow the Rust style guide.
  • Unit tests have been written where possible.

@jdunkerley jdunkerley added the CI: No changelog needed Do not require a changelog entry for this PR. label Jul 5, 2024
@jdunkerley jdunkerley added the CI: Ready to merge This PR is eligible for automatic merge label Jul 5, 2024
@mergify mergify bot merged commit d653710 into develop Jul 5, 2024
36 checks passed
@mergify mergify bot deleted the wip/jd/json-fixes branch July 5, 2024 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI: No changelog needed Do not require a changelog entry for this PR. CI: Ready to merge This PR is eligible for automatic merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants