Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tune Text.trim, fix for Text.split #10445

Merged
merged 8 commits into from
Jul 4, 2024
Merged

Conversation

jdunkerley
Copy link
Member

@jdunkerley jdunkerley commented Jul 4, 2024

Pull Request Description

  • Rename Location.Start to Location.Left.
  • Rename Location.End to Location.Right.
  • Use auto-scoping for Location.
  • Tune widgets for Text.trim.
  • Correct signature of Text.split.
  • Adjist generateLocallyUniqueIdent to not fail on bad signature.

Checklist

Please ensure that the following checklist has been satisfied before submitting the PR:

  • The documentation has been updated, if necessary.
  • Screenshots/screencasts have been attached, if there are any visual changes. For interactive or animated visual changes, a screencast is preferred.
  • All code follows the
    Scala,
    Java,
    TypeScript,
    and
    Rust
    style guides. In case you are using a language not listed above, follow the Rust style guide.
  • Unit tests have been written where possible.

@jdunkerley
Copy link
Member Author

jdunkerley commented Jul 4, 2024

Closes #10446.

@jdunkerley jdunkerley added the CI: Ready to merge This PR is eligible for automatic merge label Jul 4, 2024
@mergify mergify bot merged commit 0661f17 into develop Jul 4, 2024
40 checks passed
@mergify mergify bot deleted the wip/jd/text-trim-changes branch July 4, 2024 22:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI: Ready to merge This PR is eligible for automatic merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants