Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separating list from read function and other small tweaks. #10434

Merged
merged 17 commits into from
Jul 3, 2024

Conversation

jdunkerley
Copy link
Member

@jdunkerley jdunkerley commented Jul 3, 2024

Pull Request Description

  • Rename Faker.string_value to Faker.text_value.
  • Remove Regex.pattern_string as duplicate of Regex.pattern.
  • Sort the Date picker.
  • Rename Data.list_directory to Data.list.
  • Remove support for reading a directory.

image

image

Checklist

Please ensure that the following checklist has been satisfied before submitting the PR:

  • The documentation has been updated, if necessary.
  • Screenshots/screencasts have been attached, if there are any visual changes. For interactive or animated visual changes, a screencast is preferred.
  • All code follows the
    Scala,
    Java,
    TypeScript,
    and
    Rust
    style guides. In case you are using a language not listed above, follow the Rust style guide.
  • Unit tests have been written where possible.

@jdunkerley jdunkerley changed the title Wip/jd/list directories Separating list from read function and other small tweaks. Jul 3, 2024
Copy link
Member

@radeusgd radeusgd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just a few small questions and one remark on naming (the pattern case).

@jdunkerley jdunkerley added the CI: Ready to merge This PR is eligible for automatic merge label Jul 3, 2024
@jdunkerley jdunkerley removed the CI: Ready to merge This PR is eligible for automatic merge label Jul 3, 2024
@jdunkerley jdunkerley added the CI: Ready to merge This PR is eligible for automatic merge label Jul 3, 2024
@mergify mergify bot merged commit 9a2aed9 into develop Jul 3, 2024
35 checks passed
@mergify mergify bot deleted the wip/jd/list-directories branch July 3, 2024 22:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI: Ready to merge This PR is eligible for automatic merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants