-
Notifications
You must be signed in to change notification settings - Fork 324
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Separating list
from read
function and other small tweaks.
#10434
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Error on `Data.read` if trying to read a directory. Error on `Data.list` if trying to list a file.
Remove support from `Auto_Detect`.
jdunkerley
requested review from
radeusgd,
GregoryTravis,
AdRiley and
marthasharkey
as code owners
July 3, 2024 12:09
jdunkerley
changed the title
Wip/jd/list directories
Separating Jul 3, 2024
list
from read
function and other small tweaks.
marthasharkey
approved these changes
Jul 3, 2024
GregoryTravis
approved these changes
Jul 3, 2024
radeusgd
reviewed
Jul 3, 2024
radeusgd
reviewed
Jul 3, 2024
radeusgd
reviewed
Jul 3, 2024
distribution/lib/Standard/Base/0.0.0-dev/src/Enso_Cloud/Internal/Existing_Enso_Asset.enso
Outdated
Show resolved
Hide resolved
radeusgd
reviewed
Jul 3, 2024
distribution/lib/Standard/Database/0.0.0-dev/src/Internal/Postgres/Postgres_Dialect.enso
Outdated
Show resolved
Hide resolved
radeusgd
reviewed
Jul 3, 2024
radeusgd
approved these changes
Jul 3, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just a few small questions and one remark on naming (the pattern
case).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Faker.string_value
toFaker.text_value
.Regex.pattern_string
as duplicate ofRegex.pattern
.Data.list_directory
toData.list
.Checklist
Please ensure that the following checklist has been satisfied before submitting the PR:
Scala,
Java,
TypeScript,
and
Rust
style guides. In case you are using a language not listed above, follow the Rust style guide.