Disable UpdatingEditionProvider when running Enso CLI #10408
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JaroslavTulach
added
the
CI: No changelog needed
JaroslavTulach
added
the
CI: Clean build required
5 tasks
JaroslavTulach
commented
Jun 29, 2024
| EditionManager.makeEditionProvider( | ||
| distributionManager, | ||
| Some(languageHome), | ||
| false |
There was a problem hiding this comment.
Passing false as we want to disable updating in the production.
JaroslavTulach
commented
Jun 29, 2024
| @@ -347,7 +347,8 @@ abstract class BaseServerTest | |||
| val editionProvider = | |||
| EditionManager.makeEditionProvider( | |||
| distributionManager, | |||
| Some(languageHome) | |||
| Some(languageHome), | |||
| true | |||
There was a problem hiding this comment.
In tests, we can happily test the UpdatingEditionProvider.
JaroslavTulach
commented
Jun 29, 2024
| @@ -43,7 +43,8 @@ object DependencyPreinstaller { | |||
|
|
|||
| val editionProvider = EditionManager.makeEditionProvider( | |||
| distributionManager, | |||
| Some(languageHome) | |||
| Some(languageHome), | |||
| true | |||
There was a problem hiding this comment.
Preinstaller shall be able to download. Passing true.
JaroslavTulach
commented
Jun 29, 2024
| @@ -77,6 +87,6 @@ object EditionManager { | |||
| distributionManager: DistributionManager, | |||
| languageHome: Option[LanguageHome] = None | |||
| ): EditionManager = new EditionManager( | |||
| makeEditionProvider(distributionManager, languageHome) | |||
| makeEditionProvider(distributionManager, languageHome, false) | |||
There was a problem hiding this comment.
By default build non-updating edition manager in production.
radeusgd
approved these changes
Jul 1, 2024
Akirathan
approved these changes
Jul 2, 2024
4e6
approved these changes
Jul 2, 2024
hubertp
approved these changes
Jul 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Fixes #9231 by using
FileSystemEditionManagerand notUpdatingEditionManagerto avoid any downloads of editions.Checklist
Please ensure that the following checklist has been satisfied before submitting the PR:
Scala,
Java,
style guides.