-
Notifications
You must be signed in to change notification settings - Fork 323
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for --jvm option in Enso runner #10374
Merged
Merged
Changes from 2 commits
Commits
Show all changes
29 commits
Select commit
Hold shift + click to select a range
43929db
Support for --jvm option in Enso launcher
JaroslavTulach 7d31eab
Iterate installed GraalVM runtimes
JaroslavTulach 67f1632
feat: engineDistributionRoot parameter
4e6 e67cc87
Generate NI executable as ./built-distribution/enso-engine-0.0.0-dev-…
JaroslavTulach 8f18b2f
Ignore --jvm when already in the right JVM
JaroslavTulach 54bb7d8
Recognize JAVA_OPTS environment variable and pass it to the JVM
JaroslavTulach ec51515
Let EditionManager work with any EditionProvider, not just updating one
JaroslavTulach f1ad21b
Don't use UpdatingEditionManager in regular execution
JaroslavTulach cfedcb6
Derive languageHome from code location
JaroslavTulach 2f3e832
Search for the parser in component subdirectory
JaroslavTulach 406291e
Setup logging before processing --jvm option
JaroslavTulach cc48ec3
Providing missing argument to makeEditionProvider
JaroslavTulach 9c81fe5
Adding update flag to FakeEditionProvider
JaroslavTulach eafa192
Change log entry
JaroslavTulach 5ea0814
Benchmarks need to be executed in --jvm mode
JaroslavTulach 8c393bf
Merge remote-tracking branch 'origin/develop' into wip/jtulach/JvmOpt…
JaroslavTulach fa7a62d
Merge remote-tracking branch 'origin/develop' into wip/jtulach/JvmOpt…
JaroslavTulach 13cb3d4
native-image needs location without .exe on Windows
JaroslavTulach 3fb6a1b
There is no runner anymore
JaroslavTulach 8e4834e
Use .exe in native runner tests
JaroslavTulach 59f3087
run_benchmarks without bash script wrapper
JaroslavTulach 83f31be
Supressing question mark operator is useless here warning
JaroslavTulach 1ec943a
Updating documentation to new location of runner
JaroslavTulach 13c9518
Just return benchmarks
JaroslavTulach ffb2fb8
No need to disable linter
JaroslavTulach 60595ba
Use with_executable_extension
JaroslavTulach 49700cd
Use with_executable_extension II
JaroslavTulach 2bd08b1
cargo fmt
JaroslavTulach bbbbf25
Using longer local variable name
JaroslavTulach File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The
JVM_OPTION
takes zero or one argument. If the argument is present, it should be a path to the GraalVM to use to execute Enso process. The code below usesProcessBuilder
to construct such process - more or less the code is a copy of what is inbin/enso
andbin/enso.bat
files.When the
--jvm
option is used without additional argument, then we should somehow locate the GraalVM in the installation. CCing @4e6 and @radeusgd (as author of enso launcher which deals with similar issues) to guide this part of the implementation.