-
Notifications
You must be signed in to change notification settings - Fork 323
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename order_by
to sort
for Table
and DB_Table
.
#10372
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added deprecated placeholder. Fixed a couple of minor deprecated mistakes.
jdunkerley
requested review from
radeusgd,
GregoryTravis,
AdRiley and
marthasharkey
as code owners
June 26, 2024 14:22
jdunkerley
force-pushed
the
wip/jd/rename-order-by
branch
from
June 26, 2024 14:23
b8fce5a
to
4bf0499
Compare
GregoryTravis
approved these changes
Jun 26, 2024
AdRiley
approved these changes
Jun 26, 2024
Add value selector for get_value if_missing. Add builder for replace.
radeusgd
added a commit
that referenced
this pull request
Jun 28, 2024
radeusgd
added a commit
that referenced
this pull request
Jul 1, 2024
radeusgd
added a commit
that referenced
this pull request
Jul 2, 2024
radeusgd
added a commit
that referenced
this pull request
Jul 2, 2024
radeusgd
added a commit
that referenced
this pull request
Jul 3, 2024
radeusgd
added a commit
that referenced
this pull request
Jul 3, 2024
radeusgd
added a commit
that referenced
this pull request
Jul 4, 2024
radeusgd
added a commit
that referenced
this pull request
Jul 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
order_by
tosort
forTable
andDB_Table
.Checklist
Please ensure that the following checklist has been satisfied before submitting the PR:
Scala,
Java,
TypeScript,
and
Rust
style guides. In case you are using a language not listed above, follow the Rust style guide.