Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename order_by to sort for Table and DB_Table. #10372

Merged
merged 4 commits into from
Jun 26, 2024
Merged

Conversation

jdunkerley
Copy link
Member

@jdunkerley jdunkerley commented Jun 25, 2024

Pull Request Description

  • Rename order_by to sort for Table and DB_Table.
  • Added deprecated placeholder.
  • Fixed a couple of minor deprecated mistakes.

image

Checklist

Please ensure that the following checklist has been satisfied before submitting the PR:

  • The documentation has been updated, if necessary.
  • Screenshots/screencasts have been attached, if there are any visual changes. For interactive or animated visual changes, a screencast is preferred.
  • All code follows the
    Scala,
    Java,
    TypeScript,
    and
    Rust
    style guides. In case you are using a language not listed above, follow the Rust style guide.
  • Unit tests have been written where possible.

Added deprecated placeholder.
Fixed a couple of minor deprecated mistakes.
@jdunkerley jdunkerley marked this pull request as ready for review June 26, 2024 14:22
@jdunkerley jdunkerley force-pushed the wip/jd/rename-order-by branch from b8fce5a to 4bf0499 Compare June 26, 2024 14:23
Add value selector for get_value if_missing.
Add builder for replace.
@jdunkerley jdunkerley added the CI: Ready to merge This PR is eligible for automatic merge label Jun 26, 2024
@mergify mergify bot merged commit d920784 into develop Jun 26, 2024
34 checks passed
@mergify mergify bot deleted the wip/jd/rename-order-by branch June 26, 2024 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI: Ready to merge This PR is eligible for automatic merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants