Some drop down fixes #10337
Merged
Some drop down fixes #10337
+44
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
farmaazon
requested review from
Frizi,
vitvakatu,
kazcw and
AdRiley
as code owners
kazcw
approved these changes
Jun 21, 2024
| @@ -318,6 +339,7 @@ function toggleVectorValue(vector: Ast.MutableVector, value: string, previousSta | |||
| function expressionTagClicked(tag: ExpressionTag, previousState: boolean) { | |||
| const edit = graph.startEdit() | |||
| const tagValue = resolveTagExpression(edit, tag) | |||
| console.log('expressionTagClicked', tagValue) | |||
There was a problem hiding this comment.
Debug logging (here and 1 below)
| }), | ||
| ) | ||
|
|
||
| watch( | ||
| () => isHovered.value && !suppressArrow.value, |
There was a problem hiding this comment.
Putting this in a computed showArrow to use here and in the v-if/v-else-if would ensure that if our logic for when to show the arrow changes, it is still consistent with when we inhibit a parent arrow.
| @@ -12,6 +12,10 @@ interface SelectionArrowInfo { | |||
| /** Whether or not the arrow provided by this context instance was already requested. | |||
| * Do not request the arrow twice, it will be stolen from other elements! */ | |||
| handled: boolean | |||
| /** | |||
| * | |||
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Fixes #10185
Fixed two bugs from above issue: multiple arrows and being unable to change value from numeric input. The first was just lack of implementation; the second was caused by WidgetNumeric not handling its edit handler properly - the numeric input blur was finishing edit before click at entry could be interpreted.
Important Notes
There is still one issue with drop-down filtering; will file a bug report soon.
Checklist
Please ensure that the following checklist has been satisfied before submitting the PR:
Scala,
Java,
TypeScript,
and
Rust
style guides. In case you are using a language not listed above, follow the Rust style guide.