-
Notifications
You must be signed in to change notification settings - Fork 324
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Visualization Preview #10310
Visualization Preview #10310
Conversation
const isVisualizationVisible = computed( | ||
() => isVisualizationEnabled.value || isVisualizationPreviewed.value, | ||
) | ||
watch(isVisualizationPreviewed, (newVal, oldVal) => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This shouldn't be run when isVisualizationEnabled
.
@@ -405,14 +418,13 @@ watchEffect(() => { | |||
class="GraphNode" | |||
:style="{ | |||
transform, | |||
minWidth: isVisualizationVisible ? `${visualizationWidth ?? 200}px` : undefined, | |||
minWidth: isVisualizationEnabled ? `${visualizationWidth ?? 200}px` : undefined, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
min-width
not set when previewing?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, The previewing is so temporary, that resizing node gave bad feeling. So I decided that the node will be resized only when visualization is actually enabled.
@@ -479,9 +491,10 @@ watchEffect(() => { | |||
:width="visualizationWidth" | |||
:height="visualizationHeight" | |||
:isFocused="isOnlyOneSelected" | |||
:isPreview="isVisualizationPreviewed" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should not be set when isVisualizationEnabled
.
Pull Request Description
Fixes #8533
Visualization is shown when pressing ctrl (cmd on mac) and hovering output port.
Screencast.from.2024-06-18.17-06-59.webm
Important Notes
Checklist
Please ensure that the following checklist has been satisfied before submitting the PR:
Scala,
Java,
TypeScript,
and
Rust
style guides. In case you are using a language not listed above, follow the Rust style guide.