Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run whole test/Base_Tests with NI #10296
Run whole test/Base_Tests with NI #10296
Changes from 14 commits
29a0920
51bc321
2aa81cd
354808a
20f9589
d636711
c3a97c1
d61e5d2
dc38371
4a7a5df
6efc514
3f02060
35ca49c
501c07d
377bd2a
466f222
a9cda6f
0d902b2
31e3798
cae2521
30ce7c3
0695d1b
ec2ea1f
d03ba23
3e5e0b0
3c52ea7
07e7770
d59f6f7
9f4569a
b9d221f
5328f66
ec0918f
c2f9eb5
04bfdcd
6ab352e
961c3ec
7d73811
b222ed0
e819e74
fc24808
0dec33e
41ef406
582f3be
403e0d6
cc14d91
34424ae
71cfc0d
2b9be62
a1bff6e
4c2089f
c4fb3db
31a3de8
b2caa90
1bae374
562e611
b8b4aae
8d0684c
bfa60b4
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't these imports also be kept in
Extra_Imports.enso
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My decision making process was:
*_Spec.enso
file, put thepolyglot java import
intoExtra_Imports.enso
Standard.Base
library file, put the import into that file.In this case the failure was in
Date_Period.enso
file, I believe.