-
Notifications
You must be signed in to change notification settings - Fork 324
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement Windows-1252 fallback logic for Encoding.Default
#10190
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
radeusgd
force-pushed
the
wip/radeusgd/10148-win-1252-fallback
branch
from
June 5, 2024 17:43
fcabb8e
to
6ef7aae
Compare
concepts in the Enso side
radeusgd
force-pushed
the
wip/radeusgd/10148-win-1252-fallback
branch
from
June 7, 2024 16:21
6ef7aae
to
a059d88
Compare
radeusgd
requested review from
jdunkerley,
GregoryTravis and
AdRiley
as code owners
June 7, 2024 16:25
GregoryTravis
approved these changes
Jun 7, 2024
Tested the use-case loading the dataset https://www.kaggle.com/datasets/vivek468/superstore-dataset-final We can see that the default one works, while setting explicitly to UTF-8 has failing characters. This shows that the Default encoding correctly falls back to Windows-1252. |
jdunkerley
approved these changes
Jun 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Encoding.Default
if invalid UTF-8 characters are encountered #10148Restartable_Input_Stream
,peek_bytes
andskip_n_bytes
.Managed_Resource
stack overflow bug: StackOverflow when multiple Managed Resources are being cleaned up at the same time #10211Encoding.Default
to do only one pass on the happy path #10220Important Notes
Checklist
Please ensure that the following checklist has been satisfied before submitting the PR:
Scala,
Java,
TypeScript,
and
Rust
style guides. In case you are using a language not listed above, follow the Rust style guide.