Moving nodes or camera with arrows #10179
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
farmaazon
added
CI: No changelog needed
farmaazon
requested review from
Frizi,
vitvakatu,
kazcw and
AdRiley
as code owners
Frizi
approved these changes
Jun 5, 2024
app/gui2/src/util/data/vec2.ts
Outdated
| @@ -15,6 +15,10 @@ export class Vec2 { | |||
| return new Vec2(point.x, point.y) | |||
| } | |||
|
|
|||
| static FromTuple(point: [x: number, y: number]): Vec2 { | |||
| @@ -258,6 +271,7 @@ export function useNavigator(viewportNode: Ref<Element | undefined>, keyboard: K | |||
|
|
|||
| return proxyRefs({ | |||
| events: { | |||
| ...panArrows.events, | |||
There was a problem hiding this comment.
Not sure if it's good idea to spread those. The returned events are all bound with v-on to the wrapping div, which probably is unintentional here.
| }) | ||
| useEvent(window, 'keyup', (event) => graphNavigator.events.keyup(event)) |
There was a problem hiding this comment.
Imo this should be part of the graphNavigator itself (or even useArrows). It should be harmless to always handle keyup if all it does is ends an action that had to first be started by a handled keydown.
| export function useNavigator( | ||
| viewportNode: Ref<Element | undefined>, | ||
| keyboard: KeyboardComposable, | ||
| predicate: (e: PointerEvent | KeyboardEvent) => boolean = (_) => true, |
There was a problem hiding this comment.
I think this deserves an Options interface now.
farmaazon
removed
the
CI: No changelog needed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Fixes #10029
Screencast.from.2024-06-05.11-40-50.webm
Important Notes
Checklist
Please ensure that the following checklist has been satisfied before submitting the PR:
Scala,
Java,
TypeScript,
and
Rust
style guides. In case you are using a language not listed above, follow the Rust style guide.