Implement the ydoc js bundle test #10160
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4e6
added
the
CI: No changelog needed
JaroslavTulach
approved these changes
Jun 4, 2024
| "io.helidon.webserver" % "helidon-webserver-websocket" % helidonVersion, | ||
| "junit" % "junit" % junitVersion % Test, | ||
| "com.github.sbt" % "junit-interface" % junitIfVersion % Test, | ||
| "com.fasterxml.jackson.core" % "jackson-databind" % jacksonVersion % Test |
There was a problem hiding this comment.
Adding test only dependency is OK.
| } | ||
|
|
||
| private static final class WebServerWsListener implements WsListener { | ||
| WebServerWsListener() {} | ||
| private static final class LanguageServerConnection implements WsListener { |
There was a problem hiding this comment.
Is this a mock server, mocking language server protocol. The real Ydoc code is connecting to it and we are verifying it connects and exchanges few messages, rigth?
hubertp
approved these changes
Jun 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
close #9929
Changelog:
Important Notes
Checklist
Please ensure that the following checklist has been satisfied before submitting the PR:
Scala,
Java,
TypeScript,
and
Rust
style guides. In case you are using a language not listed above, follow the Rust style guide.