Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move common testing functionality to a separate project #10112

Merged
merged 5 commits into from
May 29, 2024

Conversation

Akirathan
Copy link
Member

@Akirathan Akirathan commented May 28, 2024

Pull Request Description

Introduce a new test-utils project, and moves the TestBase there. Moreover, TestBase is renamed to TestUtils and is no longer an abstract class.

Important Notes

test-utils project does not depend on junit, so it can be used, for example, by any benchmarks as well.

Checklist

Please ensure that the following checklist has been satisfied before submitting the PR:

  • The documentation has been updated, if necessary.
  • Screenshots/screencasts have been attached, if there are any visual changes. For interactive or animated visual changes, a screencast is preferred.
  • All code follows the
    Scala,
    Java,
    TypeScript,
    and
    Rust
    style guides. In case you are using a language not listed above, follow the Rust style guide.
  • Unit tests have been written where possible.

@Akirathan Akirathan self-assigned this May 28, 2024
@Akirathan Akirathan added the CI: No changelog needed Do not require a changelog entry for this PR. label May 28, 2024
@Akirathan Akirathan force-pushed the wip/akirathan/add-test-utils branch from c9ded92 to 7bc5781 Compare May 29, 2024 08:12
@Akirathan Akirathan added the CI: Clean build required CI runners will be cleaned before and after this PR is built. label May 29, 2024
@Akirathan Akirathan added the CI: Ready to merge This PR is eligible for automatic merge label May 29, 2024
@mergify mergify bot merged commit 56b289a into develop May 29, 2024
37 checks passed
@mergify mergify bot deleted the wip/akirathan/add-test-utils branch May 29, 2024 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI: Clean build required CI runners will be cleaned before and after this PR is built. CI: No changelog needed Do not require a changelog entry for this PR. CI: Ready to merge This PR is eligible for automatic merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants