Selection formatting toolbar #10027
Merged
Selection formatting toolbar #10027
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kazcw
requested review from
Frizi,
farmaazon,
vitvakatu and
AdRiley
as code owners
kazcw
added
the
CI: No changelog needed
|
icons incoming here #10030 |
Frizi
requested changes
May 22, 2024
There was a problem hiding this comment.
The implementation of the floating menu container should probably be based on floating-ui/vue. We already use that for dropdowns and it should simplify the component logic significantly.
Frizi
approved these changes
May 24, 2024
| @@ -411,7 +411,6 @@ declare module '@/providers/widgetRegistry' { | |||
|
|
|||
| .arrow { | |||
| position: absolute; | |||
| pointer-events: none; | |||
There was a problem hiding this comment.
This style was intentional, to avoid the arrow blinking when hovered in some cases. Whether or not it is visible should not affect the active drop-down area. What is the intention behind this change?
MrFlashAccount
pushed a commit
that referenced
this pull request
May 25, 2024
* Selection formatting toolbar * Icons * Review * Fix bold+italic rendering * Preparing for top bar * Refactor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
In the documentation panel, add a toolbar for setting formatting properties of the selected text; it floats next to the selection, and initially supports bold/italic/strikethrough.
Cf. #9969
Important Notes
Checklist
Please ensure that the following checklist has been satisfied before submitting the PR:
Scala,
Java,
TypeScript,
and
Rust
style guides. In case you are using a language not listed above, follow the Rust style guide.