Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stack trace when Enso script finishes with a Panic is upside down #9934

Closed
radeusgd opened this issue May 13, 2024 · 3 comments · Fixed by #9954
Closed

Stack trace when Enso script finishes with a Panic is upside down #9934

radeusgd opened this issue May 13, 2024 · 3 comments · Fixed by #9954
Assignees
Labels

Comments

@radeusgd
Copy link
Member

Try running the following example file:

from Standard.Base import all

a = b
b = c
c = Panic.throw "foo"

main = a

Actual behaviour

Execution finished with an error: foo
        at <enso> stack-test.main(stack-test.enso:7:8-8)
        at <enso> stack-test.a(stack-test.enso:3:5-5)
        at <enso> stack-test.b(stack-test.enso:4:5-5)
        at <enso> stack-test.c(stack-test.enso:5:5-21)
        at <enso> Panic.throw(Internal)

Expected behaviour

The panic-throw location should be at the top of the trace, the order should be reversed.

Execution finished with an error: foo
        at <enso> Panic.throw(Internal)
        at <enso> stack-test.c(stack-test.enso:5:5-21)
        at <enso> stack-test.b(stack-test.enso:4:5-5)
        at <enso> stack-test.a(stack-test.enso:3:5-5)
        at <enso> stack-test.main(stack-test.enso:7:8-8)
@JaroslavTulach
Copy link
Member

Probably result of my rewrite to Java - #9810

@JaroslavTulach JaroslavTulach self-assigned this May 14, 2024
@JaroslavTulach JaroslavTulach moved this from ❓New to 📤 Backlog in Issues Board May 14, 2024
@JaroslavTulach JaroslavTulach moved this from 📤 Backlog to 👁️ Code review in Issues Board May 14, 2024
@enso-bot
Copy link

enso-bot bot commented May 15, 2024

Jaroslav Tulach reports a new STANDUP for yesterday (2024-05-14):

Progress: - planning meeting

mergify bot pushed a commit that referenced this issue May 15, 2024
Fixes #9934 by reversing the order of `dropInitJava` frames.
@mergify mergify bot closed this as completed in #9954 May 15, 2024
@github-project-automation github-project-automation bot moved this from 👁️ Code review to 🟢 Accepted in Issues Board May 15, 2024
@enso-bot
Copy link

enso-bot bot commented May 16, 2024

Jaroslav Tulach reports a new STANDUP for yesterday (2024-05-15):

Progress: - merged stacktrace: #9954

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants