Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include project name in Database audit logs #9875

Closed
radeusgd opened this issue May 7, 2024 · 1 comment · Fixed by #10892
Closed

Include project name in Database audit logs #9875

radeusgd opened this issue May 7, 2024 · 1 comment · Fixed by #10892
Assignees
Labels
-libs Libraries: New libraries to be implemented l-cloud-integration Enso Cloud integration work

Comments

@radeusgd
Copy link
Member

radeusgd commented May 7, 2024

Follow up of #9873

We want to include project name, e.g. enso_dev.Base_Tests in the metadata of audit logs for Database connections.

Currently this is blocked by #9845.

Once the above ticket is resolved, we should update the logic and tests.

@radeusgd radeusgd added -libs Libraries: New libraries to be implemented x-on-hold l-cloud-integration Enso Cloud integration work labels May 7, 2024
@radeusgd radeusgd self-assigned this May 7, 2024
@github-project-automation github-project-automation bot moved this to ❓New in Issues Board May 7, 2024
mergify bot pushed a commit that referenced this issue May 11, 2024
- Closes #9599
- Implemented API for sending audit logs to the cloud on a background thread.
- If the Postgres connection is opened through a datalink, its internal JDBC connection is replaced by a wrapper that reports executed queries to the audit log.
- Also introduces `EnsoMeta` - a helper Java class that can be used in our helper libraries to access Enso types.
- I have replaced the common pattern scattered throughout the codebase with calls to this 'library' to avoid repetitive code.
- Refactored `Table.display` to share code between in-memory and DB - it was needed as the function stopped working for `DB_Table` after adding making the `Table` constructor `private`.
- Clearer error when reading a SQLite database from a remote file (tells the user to download it first).
- Follow up - correlate asset id of the data link:
#9869
- Follow up - include project name (once bug is fixed):
#9875
- Some problems/improvements of the audit log:
- The audit log system is not yet ready for high throughput of logs
#9870
- The logs may be lost if `System.exit` is used
#9871
@radeusgd radeusgd mentioned this issue Jun 7, 2024
4 tasks
@radeusgd radeusgd removed the x-on-hold label Jun 8, 2024
@jdunkerley jdunkerley moved this from ❓New to 📤 Backlog in Issues Board Jun 11, 2024
@jdunkerley jdunkerley moved this from 📤 Backlog to ⚙️ Design in Issues Board Jun 19, 2024
@jdunkerley jdunkerley moved this from ⚙️ Design to 📤 Backlog in Issues Board Jun 19, 2024
@jdunkerley jdunkerley added this to the 2024-08 Release milestone Jul 29, 2024
@enso-bot
Copy link

enso-bot bot commented Aug 27, 2024

Radosław Waśko reports a new STANDUP for yesterday (2024-08-26):

Progress: Re-introduced getting current project in Java code and enabled it in audit logs. Updated tests. Put the PR. It should be finished by 2024-08-27.

Next Day: Next day I will be working on the #9870 task. Audit log batching - in separate PR.

@mergify mergify bot closed this as completed in #10892 Aug 27, 2024
@mergify mergify bot closed this as completed in ff5e4c4 Aug 27, 2024
@github-project-automation github-project-automation bot moved this from 👁️ Code review to 🟢 Accepted in Issues Board Aug 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
-libs Libraries: New libraries to be implemented l-cloud-integration Enso Cloud integration work
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants