Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GUI project does not receive suggestion database. #9558

Closed
farmaazon opened this issue Mar 27, 2024 · 5 comments · Fixed by #9634
Closed

GUI project does not receive suggestion database. #9558

farmaazon opened this issue Mar 27, 2024 · 5 comments · Fixed by #9634
Assignees
@hubertp
Labels
--bug Type: bug -language-server p-high Should be completed in the next sprint

Comments

@farmaazon
Copy link
Contributor

Very often, when I open a project, GUI does not receive suggestion database. Sometimes I see only local variables.

image

The logs from today, right after opening a project which has not received any suggestion entry (above screenshot):

enso-project-manager-2024-03-27.0.log
@JaroslavTulach JaroslavTulach added the p-high Should be completed in the next sprint label Apr 3, 2024
@JaroslavTulach JaroslavTulach moved this from ❓New to 📤 Backlog in Issues Board Apr 3, 2024
@JaroslavTulach
Copy link
Member

I am facing these issues often. Even so often that I wasn't able to do a bookclub for last two weeks.

@hubertp
Copy link
Collaborator

hubertp commented Apr 4, 2024

I got it today as well. Looks like while DeserializeLibrarySuggestionsCmd is run, the DeserializeLibrarySuggestionsJob background job that it submits is never triggered. Will investigate.

@hubertp
Copy link
Collaborator

hubertp commented Apr 4, 2024

Potentially a regression introduced in #9142

@hubertp
Copy link
Collaborator

hubertp commented Apr 4, 2024

enso-no-suggestions-db.log
Logs from my execution. Clearing of suggestions DB is never triggered.

@hubertp
Copy link
Collaborator

hubertp commented Apr 4, 2024 •
edited
Loading

As debugged with @4e6, InvalidateModulesIndexCommand takes too long to complete (requires write compilation lock) and its handler timeouts and never sends a message to clear suggestions' DB.

@4e6 4e6 mentioned this issue Apr 4, 2024
Merged
4 tasks
@enso-bot enso-bot bot mentioned this issue Apr 5, 2024
Closed
@mergify mergify bot closed this as completed in #9634 Apr 8, 2024
mergify bot pushed a commit that referenced this issue Apr 8, 2024
@4e6
GUI project does not receive suggestion database (#9634)
ab552ab 
close #9558

the `InvalidateModulesIndexCommand` may be waiting for the execution lock, while the handler times out.
@github-project-automation github-project-automation bot moved this from 📤 Backlog to 🟢 Accepted in Issues Board Apr 8, 2024
@hubertp hubertp mentioned this issue May 3, 2024
Merged
4 tasks
mergify bot pushed a commit that referenced this issue May 6, 2024
@hubertp
Workaround slow responses with retries (#9858)
459a264 
Follow up to #9558, this time to `SetExecutionContextEnvironmentHandler` that was timing out in #9789.
Added a base classes that handles the repeatable logic.

Maybe it will close #9789.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hubertp hubertp

Labels
--bug Type: bug -language-server p-high Should be completed in the next sprint
Projects
Issues Board
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

GUI project does not receive suggestion database enso-org/enso
3 participants
@hubertp @farmaazon @JaroslavTulach