Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Text escaping broken when dragging in a file for data read. #9151

Closed
AdRiley opened this issue Feb 23, 2024 · 1 comment · Fixed by #9155
Closed

Text escaping broken when dragging in a file for data read. #9151

AdRiley opened this issue Feb 23, 2024 · 1 comment · Fixed by #9155
Assignees
Labels
--bug Type: bug -gui p-highest Should be completed ASAP
Milestone

Comments

@AdRiley
Copy link
Member

AdRiley commented Feb 23, 2024

If I drag a file onto the background then it is not getting properly escaped.

image

Found in build ide2-enso-win-x64-2024.1.1-nightly.2024.2.23

Build ide2-enso-win-x64-2024.1.1-nightly.2024.2.22 works as expected

image

@AdRiley AdRiley added p-highest Should be completed ASAP --bug Type: bug -gui labels Feb 23, 2024
@AdRiley AdRiley added this to the Beta Release milestone Feb 23, 2024
@farmaazon farmaazon self-assigned this Feb 23, 2024
@farmaazon farmaazon moved this from ❓New to 🔧 Implementation in Issues Board Feb 23, 2024
@farmaazon farmaazon mentioned this issue Feb 23, 2024
4 tasks
@mergify mergify bot closed this as completed in #9155 Feb 23, 2024
mergify bot pushed a commit that referenced this issue Feb 23, 2024
Fixes #9151

In one of my previous PRs I merged two `escape` implementations having exactly the same documentation. However, one of it missed escaping `\` character.

# Important Notes
One test even expected that `\` are _not_ escaped, but I doubt it should, given the above bug report?
@github-project-automation github-project-automation bot moved this from 🔧 Implementation to 🟢 Accepted in Issues Board Feb 23, 2024
@enso-bot
Copy link

enso-bot bot commented Feb 23, 2024

Adam Obuchowicz reports a new STANDUP for today (2024-02-23):

Progress: No progress on Drop-down fitering, as I was busy with fixing regressions, and then cleaning board a little. It should be finished by 2024-02-23.

Next Day: Next day I will be working on the #9058 task. Catch up with the progress - easier as there's no demo meeting on Monday.

@farmaazon farmaazon moved this from 🟢 Accepted to 🗄️ Archived in Issues Board Mar 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
--bug Type: bug -gui p-highest Should be completed ASAP
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants