Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Visualization Small Fixes #9009

Closed
4 tasks done
Tracked by #9007
AdRiley opened this issue Feb 8, 2024 · 8 comments · Fixed by #9130
Closed
4 tasks done
Tracked by #9007

Visualization Small Fixes #9009

AdRiley opened this issue Feb 8, 2024 · 8 comments · Fixed by #9130
Assignees
@vitvakatu
Labels
--bug Type: bug -gui d-easy Difficulty: little prior knowledge required p-high Should be completed in the next sprint
Milestone
Beta Release

Comments

@AdRiley
Copy link
Member

AdRiley commented Feb 8, 2024 •
edited by vitvakatu
Loading

Tasks
Preview Give feedback
@AdRiley AdRiley added p-high Should be completed in the next sprint -gui labels Feb 8, 2024
@AdRiley AdRiley added this to the Beta Release milestone Feb 8, 2024
@github-project-automation github-project-automation bot moved this to ❓New in Issues Board Feb 8, 2024
@AdRiley AdRiley mentioned this issue Feb 8, 2024
Closed
@farmaazon farmaazon added d-easy Difficulty: little prior knowledge required --bug Type: bug labels Feb 12, 2024
@farmaazon farmaazon moved this from ❓New to 📤 Backlog in Issues Board Feb 14, 2024
@vitvakatu vitvakatu moved this from 📤 Backlog to 🔧 Implementation in Issues Board Feb 19, 2024
@vitvakatu
Copy link
Contributor

I moved last point to #8708

@vitvakatu vitvakatu mentioned this issue Feb 22, 2024
Merged
9 tasks
@vitvakatu vitvakatu moved this from 🔧 Implementation to 👁️ Code review in Issues Board Feb 22, 2024
@enso-bot
Copy link

enso-bot bot commented Feb 22, 2024

Ilya Bogdanov reports a new STANDUP for yesterday (2024-02-21):

Progress: Implementing serialization of visualization width and escape key closing fullscreen visualizations. Serialization required changes in ydoc-server files, luckily I quickly found what to adjust. Managing event handlers priorities for escape key is hard. It should be finished by 2024-02-23.

@enso-bot
Copy link

enso-bot bot commented Feb 27, 2024

Ilya Bogdanov reports a new 🔴 DELAY for yesterday (2024-02-26):

Summary: There is 5 days delay in implementation of the Visualization Small Fixes (#9009) task.
It will cause 0 days delay for the delivery of this weekly plan.

2 days are weekends

Delay Cause: Focus issues raised on review take a lot of time to investigate and fix.

@enso-bot
Copy link

enso-bot bot commented Feb 27, 2024

Ilya Bogdanov reports a new STANDUP for yesterday (2024-02-26):

Progress: Debugging, experimenting with different focus management rules for visualizations. It should be finished by 2024-02-28.

@mergify mergify bot closed this as completed in #9130 Feb 29, 2024
mergify bot pushed a commit that referenced this issue Feb 29, 2024
@vitvakatu
Small visualization fixes (#9130)
c44b7f2 
Closes #9009

- [x] Fixed big white space above full screen viz.
- [x] Escape closes the full screen visualization.
- [x] Viz shortcuts (Shift-Space for toggling fullscreen vis, Ctrl-Space for switching vis type) are implemented.
- [x] The width of visualizations is preserved across project reopens (do we need height as well?)

New video:


https://github.com/enso-org/enso/assets/6566674/d9036ce9-57a4-429b-9bd9-6392782136ea

Older videos:

https://github.com/enso-org/enso/assets/6566674/d7129307-0626-4343-8a76-b9bf764c6a5b


https://github.com/enso-org/enso/assets/6566674/0518d3d8-9ed1-4e6c-bbe0-b7ed00bf7db3

# Important Notes
- Metadata format changed in backward-compatible way
@github-project-automation github-project-automation bot moved this from 👁️ Code review to 🟢 Accepted in Issues Board Feb 29, 2024
@farmaazon farmaazon moved this from 🟢 Accepted to 🗄️ Archived in Issues Board Mar 5, 2024
@enso-bot
Copy link

enso-bot bot commented Apr 15, 2024

Ilya Bogdanov reports a new STANDUP for the provided date (2024-02-19):

Progress: Opened a PR for imports conflicts resolution after final cleanups. Starting to work on visualization fixes, debugging and learning the codebase. Fixed layout issues. It should be finished by 2024-02-28.

@enso-bot
Copy link

enso-bot bot commented Apr 15, 2024

Ilya Bogdanov reports a new STANDUP for the provided date (2024-02-22):

Progress: Refactorings, alternative event handling implementation, cleanups. Opened a PR for reviews. It should be finished by 2024-02-28.

@enso-bot
Copy link

enso-bot bot commented Apr 15, 2024

Ilya Bogdanov reports a new STANDUP for the provided date (2024-02-23):

Progress: After receiving feedback on review, working on addressing review comments, merging with develop, more cleanups. It should be finished by 2024-02-28.

@enso-bot
Copy link

enso-bot bot commented Apr 15, 2024

Ilya Bogdanov reports a new STANDUP for the provided date (2024-02-27):

Progress: Finished cleanups and pushed changes for second review. Fixing e2e tests broken because of the merge conflict. It should be finished by 2024-02-28.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vitvakatu vitvakatu

Labels
--bug Type: bug -gui d-easy Difficulty: little prior knowledge required p-high Should be completed in the next sprint
Projects
Issues Board
Archived in project
Milestone
Beta Release
Development

Successfully merging a pull request may close this issue.

Small visualization fixes enso-org/enso
3 participants
@AdRiley @farmaazon @vitvakatu