Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deduplicate public facing type names to avoid issues with input #8981

Closed
jdunkerley opened this issue Feb 6, 2024 · 0 comments · Fixed by #9098
Closed

Deduplicate public facing type names to avoid issues with input #8981

jdunkerley opened this issue Feb 6, 2024 · 0 comments · Fixed by #9098
Assignees
@AdRiley
Labels
--bug Type: bug -libs Libraries: New libraries to be implemented

Comments

@jdunkerley
Copy link
Member

Want to rename:

  • Standard.Database.Data.SQL.Builder => Standard.Database.Data.SQL.SQL_Builder
  • Standard.Database.Data.Column.Column => Standard.Database.Data.DB_Column.DB_Column
  • Standard.Database.Data.Table.Table => Standard.Database.Data.DB_Table.DB_Table

Want to merge the 3 Empty_Error into 1.

Move Standard.Database.Data.Table.Wrapped_Error into a private module and avoid exporting, and pick a new name!

Where possible remove any aliases.
@jdunkerley jdunkerley added --bug Type: bug -libs Libraries: New libraries to be implemented labels Feb 6, 2024
@github-project-automation github-project-automation bot moved this to ❓New in Issues Board Feb 6, 2024
@jdunkerley jdunkerley moved this from ❓New to 📤 Backlog in Issues Board Feb 6, 2024
@AdRiley AdRiley moved this from 📤 Backlog to 🔧 Implementation in Issues Board Feb 7, 2024
This was referenced Feb 12, 2024
Merged
Merged
mergify bot pushed a commit that referenced this issue Feb 12, 2024
@AdRiley
Rename wrapped_error and make it private (#9030)
6739426 
Rename wrapped_error to DB_wrapped_error and make it private to avoid name clashes as part of #8981
@AdRiley AdRiley mentioned this issue Feb 13, 2024
Merged
5 tasks
mergify bot pushed a commit that referenced this issue Feb 14, 2024
@AdRiley
Rename database column to DB_Column (#9046)
5c7947c 
Rename database column to DB_Column to avoid name collisions as part of #8981
This was referenced Feb 19, 2024
Merged
Merged
mergify bot pushed a commit that referenced this issue Feb 19, 2024
@AdRiley
rename database Table to DB_Table (#9067)
27ec236 
Rename database.Table to database.DB_Table to avoid name collisions as part of #8981
@mergify mergify bot closed this as completed in #9098 Feb 20, 2024
mergify bot pushed a commit that referenced this issue Feb 20, 2024
@AdRiley
Remove table aliases (#9098)
4cbdc9d 
Now Table and DB_Table have different names we can remove a lot of aliases. This closes #8981
@github-project-automation github-project-automation bot moved this from 🔧 Implementation to 🟢 Accepted in Issues Board Feb 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AdRiley AdRiley

Labels
--bug Type: bug -libs Libraries: New libraries to be implemented
Projects
Issues Board
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove table aliases enso-org/enso
2 participants
@AdRiley @jdunkerley