Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run unit tests with truffle-compiler #8374

Closed
Akirathan opened this issue Nov 23, 2023 · 10 comments · Fixed by #8467
Closed

Run unit tests with truffle-compiler #8374

Akirathan opened this issue Nov 23, 2023 · 10 comments · Fixed by #8467
Assignees
Labels
-compiler -tooling Category: tooling d-easy Difficulty: little prior knowledge required p-medium Should be completed in the next few sprints x-chore Type: chore

Comments

@Akirathan
Copy link
Member

Since #7991, all the unit tests are run without truffle-compiler and with -Dpolyglot.engine.WarnInterpreterOnly=false to suppress the warning. Apparently, this makes the tests very slow. Moreover, it makes the WithDebug command to fail on "Could not find option with name engine.BackgroundCompilation".

Let's add truffle-compiler to the tests.

@Akirathan Akirathan added d-easy Difficulty: little prior knowledge required -tooling Category: tooling p-medium Should be completed in the next few sprints x-chore Type: chore -compiler labels Nov 23, 2023
@Akirathan Akirathan self-assigned this Nov 23, 2023
@Akirathan Akirathan moved this from ❓New to 📤 Backlog in Issues Board Nov 23, 2023
@enso-bot
Copy link

enso-bot bot commented Dec 4, 2023

Pavel Marek reports a new STANDUP for today (2023-12-04):

Progress: - Tweaking the sbt build so that it invokes tests with proper module-path

  • Tried to invoke it with class-path and -Dpolyglotimpl.DisableClassPathIsolation=false but that does not work. It should be finished by 2023-12-08.

@enso-bot
Copy link

enso-bot bot commented Dec 5, 2023

Pavel Marek reports a new STANDUP for today (2023-12-05):

Progress: - Properly configure --module-path, --patch-module, and other options to be able to run VectorTests with truffle-compiler, enso lang and all other required modules

  • Add custom default test logging config file for ch.qos.logback.
    • We cannot use our own logging framework, because it is not JPMS module ready, so let's simplify it in the test and just use ch.qos.logback directly with a custom config file.
  • Can successfully run sbt:runtime> testOnly *VectorTests.
  • Cannot run scala tests, they have different test runner.
    • Scala test runner cannot locate the Scala test classes? It should be finished by 2023-12-08.

@Akirathan Akirathan moved this from 📤 Backlog to 🔧 Implementation in Issues Board Dec 6, 2023
@enso-bot
Copy link

enso-bot bot commented Dec 6, 2023

Pavel Marek reports a new STANDUP for today (2023-12-06):

Progress: - Optimizing sbt build - do not copy hundreds of classes before every test unless necessary

  • Refactoring sbt build - move runtime.jar assembling into a separate runtime-fat-jar meta project
  • Still cannot run scala tests.
    • Tried to compile scala code to bytecode version 17 but does not work either. It should be finished by 2023-12-08.

@enso-bot
Copy link

enso-bot bot commented Dec 7, 2023

Pavel Marek reports a new STANDUP for today (2023-12-07):

Progress: - Dealing with suspicious class loading failures once again.

  • Still unable to load some test classes. It should be finished by 2023-12-08.

@enso-bot
Copy link

enso-bot bot commented Dec 8, 2023

Pavel Marek reports a new STANDUP for today (2023-12-08):

Progress: - Resolved the issue with class loading of test - it was caused by split packages.

  • runtime / test now works
  • Making sure that other tests in other projects include truffle-compiler.
    • Also that they do not assembly any fat jar.
  • Discussion about adding new org.jline module into the engine distribution's component directory. It should be finished by 2023-12-08.

@enso-bot
Copy link

enso-bot bot commented Dec 11, 2023

Pavel Marek reports a new 🔴 DELAY for today (2023-12-11):

Summary: There is 7 days delay in implementation of the Run unit tests with truffle-compiler (#8374) task.
It will cause 7 days delay for the delivery of this weekly plan.

Delay Cause: Tweaking the sbt build to properly provide truffle-compiler into all the unit tests is more difficult than expected.

@enso-bot
Copy link

enso-bot bot commented Dec 11, 2023

Pavel Marek reports a new STANDUP for today (2023-12-11):

Progress: - We have some instruments in runtime/Test that are used only for testing.

  • We do not want those to be declared in runtime/module-info.java.
  • There are many split packages in runtime/Test and runtime/Compile.
    • Test classes in such packages access package-private members from runtime/Compile.
    • This causes troubles for the Java module system.
    • One solution is to patch the split packages in org.enso.runtime module.
      • But then, Truffle cannot locate the testing instruments in runtime/Test.
    • Experimenting with some solutions:
      • Move the testing instruments to a separate project and compile it as an explicit org.enso.runtime.test module.
        • Gave up, there were too many problems with cyclic dependencies and others.
      • Lets make runtime/Test an explicit module It should be finished by 2023-12-15.

@enso-bot
Copy link

enso-bot bot commented Dec 12, 2023

Pavel Marek reports a new STANDUP for today (2023-12-12):

Progress: - Fixed runtime/test and runtime-with-instruments/test.

  • They both run with truffle compiler and do not reassemble any fat jars It should be finished by 2023-12-15.

@enso-bot
Copy link

enso-bot bot commented Dec 15, 2023

Pavel Marek reports a new STANDUP for yesterday (2023-12-14):

Progress: - Inverted dependencies of runtime-test-instruments

  • Pushed bump of Java formatter plugin version
  • Merged runtime-with-polyglot and runtime-with-instruments into runtime/Test. It should be finished by 2023-12-15.

@enso-bot
Copy link

enso-bot bot commented Dec 15, 2023

Pavel Marek reports a new STANDUP for today (2023-12-15):

Progress: - Adding truffle-compiler to language-server tests It should be finished by 2023-12-15.

@github-project-automation github-project-automation bot moved this from 🔧 Implementation to 🟢 Accepted in Issues Board Dec 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
-compiler -tooling Category: tooling d-easy Difficulty: little prior knowledge required p-medium Should be completed in the next few sprints x-chore Type: chore
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant