Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

--server-profiling-path does nothing #8156

Closed
JaroslavTulach opened this issue Oct 26, 2023 · 3 comments · Fixed by #8254 or #8266
Closed

--server-profiling-path does nothing #8156

JaroslavTulach opened this issue Oct 26, 2023 · 3 comments · Fixed by #8254 or #8266

Comments

@JaroslavTulach
Copy link
Member

JaroslavTulach commented Oct 26, 2023

I'd like to profile/log what is happening during startup. Running:

enso$ ./built-distribution/enso-engine-0.0.0-*/enso-0.0.0-dev/bin/enso \
  --run ~/enso/projects/Empty/ \
  --server-profiling-path start.npss \ 
  --server-profiling-events-log-path start.log \
  --server-profiling-time 10

however doesn't generate start.npss neither start.log files. What's wrong? Answer: the profiling options only work with --server argument! Why? They are helpful for understanding what's happening during startup in general. They would work with --run as well as --repl!

@enso-bot
Copy link

enso-bot bot commented Nov 8, 2023

Dmitry Bushev reports a new STANDUP for yesterday (2023-11-07):

Progress: Started working on the task. Implemented the profiling logic in the runner. Removed profiling from the language server startup logic. Started testing It should be finished by 2023-11-08.

Next Day: Next day I will be working on the #8156 task. Continue working on the task

@enso-bot
Copy link

enso-bot bot commented Nov 8, 2023

Dmitry Bushev reports a new STANDUP for today (2023-11-08):

Progress: Continue working on the task. Had to recover the language server profiling logic as the collection of profiling events was not working if started in the runner. Updated the runner logic. Tested manually. Created the PR It should be finished by 2023-11-08.

Next Day: Next day I will be working on the #8156 task. Continue working on the task

@mergify mergify bot closed this as completed in #8254 Nov 8, 2023
@github-project-automation github-project-automation bot moved this from 📤 Backlog to 🟢 Accepted in Issues Board Nov 8, 2023
@JaroslavTulach
Copy link
Member Author

JaroslavTulach commented Nov 9, 2023

There still seems to be:

    --server-profiling-events-log-path <file>   The path to the runtime
                                                events log file.

I also tried:

./built-distribution/enso-engine-0.0.0-dev-linux-amd64/enso-0.0.0-dev/bin/enso --profiling-path x.npss --run ~/hi.enso

and no x.npss file was created. Reopening - I'd say that --profiling-path parameter still does nothing. Tested on 6be94a8

What can be done? Either using --profiling-path without --profiling-time shall be forbidden or there should be a shutdown code that makes sure the dump is saved when the JVM exists.

@JaroslavTulach JaroslavTulach reopened this Nov 9, 2023
@github-project-automation github-project-automation bot moved this from 🟢 Accepted to ❓New in Issues Board Nov 9, 2023
@4e6 4e6 mentioned this issue Nov 9, 2023
3 tasks
@4e6 4e6 moved this from ❓New to 👁️ Code review in Issues Board Nov 9, 2023
@mergify mergify bot closed this as completed in #8266 Nov 9, 2023
mergify bot pushed a commit that referenced this issue Nov 9, 2023
close #8156

Followup to #8254. For some reason, I did not commit this change to the original PR.
@github-project-automation github-project-automation bot moved this from 👁️ Code review to 🟢 Accepted in Issues Board Nov 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
3 participants