-
Notifications
You must be signed in to change notification settings - Fork 326
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support BigInteger columns in in-memory Table
#7712
Comments
Radosław Waśko reports a new STANDUP for yesterday (2023-09-05): Progress: Fixing comparisons, removing checks preventing BigInt ops. Testing. Adding edge case tests and handler to delete_rows - I have only now noticed a NULL edge case that needed handling. Changed IN to EXISTS as apparently that is more optimizer friendly. Discussions on problem handling. It should be finished by 2023-09-07. Next Day: Next day I will be working on the same task. Finalize delete_rows. Add tests for BigInt operations and ensure all is working. Remove obsolete warnings. |
Radosław Waśko reports a new STANDUP for today (2023-09-06): Progress: Fighting with a weird stacktrace bug found in delete_rows tests. Created an issue in oracle/graal and a PR with a fix. That fixes an inconsistency but our bug is more complex. Created a workaround for the bug. Found issue where table naming scheme was not used and an internal table was exceeding the table name length limit - fixed it. Updated the PR - ready for re-review. Updating BigInteger tests, adding tests for handling of arithmetic. Fixing edge cases. Many tests are passing but still some failures to address. It should be finished by 2023-09-07. Next Day: Next day I will be working on the same task. Fix the remaining tests and prepare the PR for re-review. |
Radosław Waśko reports a new STANDUP for today (2023-09-07): Progress: finally delete rows is merged. Prepared the big integers PR ready for review. Forgot about one small test - will fix on Monday. Did the book club. Reviews. It should be finished by 2023-09-07. Next Day: Next day I will be working on the #7461 task. fix remaining test. look into next tasks |
Radosław Waśko reports a new 🔴 DELAY for today (2023-09-11): Summary: There is 6 days delay in implementation of the Support BigInteger columns in in-memory Half of delay magnitude stems from the fact that working on the feature crossed my 1day time-off and the weekend. Delay Cause: The small test case turned out to be quite a rabbit hole, but we decided that since we support BigInteger columns in-memory, we also want the integration with Database to correctly download such columns as BigInteger, wherever possible. Some more time needed to finish it. |
Radosław Waśko reports a new STANDUP for today (2023-09-11): Progress: The small test case turned out to be quite a rabbit hole, but we decided that since we support BigInteger columns in-memory, we also want the integration with Database to correctly download such columns as BigInteger, wherever possible. Working on that feature (adding tests for it, updating column fetcher, statement setter, updating the type mappings). Meetings, some pair programming with James on Managed Resources. Catching up. It should be finished by 2023-09-13. Next Day: Next day I will be working on the same task. Continue fixing the biginteger round-trip example - ensure what set of warnings is sane. |
Radosław Waśko reports a new STANDUP for yesterday (2023-09-12): Progress: Cleanup, addressing comments, got the biginteger PR merged. Reviews. Started looking into how to address the Date.parse format issues - experimenting with adding a sum type with a simple default and customization options. It should be finished by 2023-09-12. Next Day: Next day I will be working on the #7461 task. implement a prototype and experiment with it |
Enso supports big integers seamlessly - an
Integer
is stored as along
if it fits, and if it doesn't, it gets 'promoted' toBigInteger
.However, our
Table
library only supportsLongStorage
and does not handle big integers at all.To achieve parity with the core language, we should allow the table to support big integers as well.
BigIntegerStorage
to the in-memory table.long
if the integers are small enough and falls back intoBigInteger
only for large values, but I think from the perspective of simplicity it may be better to just go for uniform storage.Decimal
Value_Type
withscale=0
(meaning no digits after decimal point).scale > 0
support will come as a separate ticket since it would requireBigDecimal
support which the language does not yet have.InferredBuilder
to promote toBigIntegerStorage
if too large integer is encountered.Decimal
column.Column_Fetcher
can support big integers when reading Decimal type columns.The text was updated successfully, but these errors were encountered: