Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pressing Cmd is closing the visualization #7457

Closed
1 of 2 tasks
sylwiabr opened this issue Aug 1, 2023 · 3 comments · Fixed by #7798
Closed
1 of 2 tasks

Pressing Cmd is closing the visualization #7457

sylwiabr opened this issue Aug 1, 2023 · 3 comments · Fixed by #7798
Assignees
@vitvakatu
Labels
--bug Type: bug --regression Important: regression -viz d-easy Difficulty: little prior knowledge required p-high Should be completed in the next sprint
Milestone
Beta Release

Comments

@sylwiabr
Copy link
Member

sylwiabr commented Aug 1, 2023

Discord username

No response

What type of issue is this?

Permanent – Occurring repeatably

Is this issue blocking you from using Enso?

  • Yes, I can't use Enso because of this issue.

Is this a regression?

  • Yes, previous version of Enso did not have this issue.

What issue are you facing?

Hovering over visualization and pressing Cmd is causing visualization to hide when the cursor position change (move away from the visualization).

Expected behaviour

Cmd should not hide the visualization

How we can reproduce it?

No response

Screenshots or screencasts

No response

Logs

No response

Enso Version

nightly 1.08

Browser or standalone distribution

Standalone distribution (local project)

Browser Version or standalone distribution

standalone

Operating System

MacOS

Operating System Version

No response

Hardware you are using

No response
@sylwiabr sylwiabr added --bug Type: bug triage labels Aug 1, 2023
@github-project-automation github-project-automation bot moved this to ❓New in Issues Board Aug 1, 2023
@sylwiabr sylwiabr added -gui -viz --regression Important: regression labels Aug 1, 2023
@jdunkerley
Copy link
Member

Ctrl on Windows does this too.

@farmaazon
Copy link
Contributor

I've reproduced it. I suspect the issue is that we switch visualization's ViewState to preview when it was enabled. If yes, then it was introduced by #7158

@farmaazon farmaazon self-assigned this Aug 4, 2023
@farmaazon farmaazon added g-graph-editor d-easy Difficulty: little prior knowledge required p-high Should be completed in the next sprint and removed triage labels Aug 4, 2023
@farmaazon farmaazon moved this from ❓New to 📤 Backlog in Issues Board Aug 7, 2023
@jdunkerley jdunkerley added this to the Beta Release milestone Aug 30, 2023
@vitvakatu vitvakatu moved this from 📤 Backlog to 🔧 Implementation in Issues Board Sep 11, 2023
@vitvakatu vitvakatu mentioned this issue Sep 12, 2023
Merged
5 tasks
@vitvakatu vitvakatu moved this from 🔧 Implementation to 👁️ Code review in Issues Board Sep 12, 2023
@enso-bot
Copy link

enso-bot bot commented Sep 12, 2023

Ilya Bogdanov reports a new STANDUP for yesterday (2023-09-11):

Progress: Debugged and fixed the issue. It should be finished by 2023-09-12.

@farmaazon farmaazon moved this from 👁️ Code review to 🟢 Accepted in Issues Board Sep 13, 2023
@mergify mergify bot closed this as completed in #7798 Sep 13, 2023
mergify bot pushed a commit that referenced this issue Sep 13, 2023
@vitvakatu
Fix visualization closing when cmd shortcut is pressed (#7798)
51491c1 
Fixes #7457

The issue was caused by the FRP logic that assumed we wanted to close the preview even if it wasn't opened in the first place.

https://github.com/enso-org/enso/assets/6566674/ceb4996b-c878-4ff1-8bca-7d2a0b817769
@farmaazon farmaazon moved this from 🟢 Accepted to 🗄️ Archived in Issues Board Sep 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vitvakatu vitvakatu

Labels
--bug Type: bug --regression Important: regression -viz d-easy Difficulty: little prior knowledge required p-high Should be completed in the next sprint
Projects
Issues Board
Archived in project
Milestone
Beta Release
Development

Successfully merging a pull request may close this issue.

Fix visualization closing when cmd shortcut is pressed enso-org/enso
5 participants
@MichaelMauderer @farmaazon @jdunkerley @vitvakatu @sylwiabr