Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert in-memory Column.round to Java #7400

Closed
GregoryTravis opened this issue Jul 25, 2023 · 9 comments · Fixed by #7521
Closed

Convert in-memory Column.round to Java #7400

GregoryTravis opened this issue Jul 25, 2023 · 9 comments · Fixed by #7521
Assignees
Labels
-libs Libraries: New libraries to be implemented p-low Low priority

Comments

@GregoryTravis
Copy link
Contributor

  • Use implementations in Core_Math_Utils
  • Benchmark to determine which implementation to use
@GregoryTravis GregoryTravis added p-low Low priority -libs Libraries: New libraries to be implemented labels Jul 25, 2023
@GregoryTravis GregoryTravis self-assigned this Jul 25, 2023
@GregoryTravis GregoryTravis moved this from ❓New to 📤 Backlog in Issues Board Jul 25, 2023
@GregoryTravis GregoryTravis moved this from 📤 Backlog to 🔧 Implementation in Issues Board Aug 3, 2023
@enso-bot
Copy link

enso-bot bot commented Aug 4, 2023

Greg Travis reports a new STANDUP for today (2023-08-04):

Progress: Figuring out how to parameterize a map op It should be finished by 2023-08-09.

Next Day: same

@enso-bot
Copy link

enso-bot bot commented Aug 7, 2023

Greg Travis reports a new STANDUP for today (2023-08-07):

Progress: Vectorized column rounding

  • Implemented decimal op
  • Updated JMH benchmark conversion of Numeric benchmarks It should be finished by 2023-08-09.

Next Day: same

@enso-bot
Copy link

enso-bot bot commented Aug 8, 2023

Greg Travis reports a new STANDUP for today (2023-08-08):

Progress: Integer vectorized rounding

  • Fixed error handling
  • De-generalized Ops
  • Final benchmarking
  • Specialize to return type for double rounding It should be finished by 2023-08-09.

Next Day: review

@enso-bot
Copy link

enso-bot bot commented Aug 9, 2023

Greg Travis reports a new STANDUP for today (2023-08-09):

Progress: Benchmark Jaroslav's builtin round optimizations

  • Get tests passing again / cleanup
  • Column rounding review changes
  • Investigate build failure It should be finished by 2023-08-09.

Next Day: Build failure, probably

@enso-bot
Copy link

enso-bot bot commented Aug 10, 2023

Greg Travis reports a new 🔴 DELAY for today (2023-08-10):

Summary: There is 1 days delay in implementation of the Convert in-memory Column.round to Java (#7400) task.
It will cause 0 days delay for the delivery of this weekly plan.

Delay Cause: review

@enso-bot
Copy link

enso-bot bot commented Aug 10, 2023

Greg Travis reports a new STANDUP for today (2023-08-10):

Progress: Review

  • Updated error handling
  • Bigint handling It should be finished by 2023-08-10.

Next Day: column rounding

@GregoryTravis GregoryTravis moved this from 🔧 Implementation to 👁️ Code review in Issues Board Aug 11, 2023
@enso-bot
Copy link

enso-bot bot commented Aug 11, 2023

Greg Travis reports a new 🔴 DELAY for today (2023-08-11):

Summary: There is 3 days delay in implementation of the Convert in-memory Column.round to Java (#7400) task.
It will cause 0 days delay for the delivery of this weekly plan.

Delay Cause: review

@enso-bot
Copy link

enso-bot bot commented Aug 11, 2023

Greg Travis reports a new 🔴 DELAY for today (2023-08-11):

Summary: There is 1 days delay in implementation of the Convert in-memory Column.round to Java (#7400) task.
It will cause 0 days delay for the delivery of this weekly plan.

Delay Cause: review

@enso-bot
Copy link

enso-bot bot commented Aug 11, 2023

Greg Travis reports a new STANDUP for today (2023-08-11):

Progress: Review

  • Round builtin review
  • Col Round builtin review It should be finished by 2023-08-14.

Next Day: take/drop

@jdunkerley jdunkerley linked a pull request Aug 15, 2023 that will close this issue
5 tasks
@mergify mergify bot closed this as completed in #7521 Aug 16, 2023
@github-project-automation github-project-automation bot moved this from 👁️ Code review to 🟢 Accepted in Issues Board Aug 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
-libs Libraries: New libraries to be implemented p-low Low priority
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant