Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing icons in new Component Browser #7260

Closed
23 tasks
Tracked by #7125
vitvakatu opened this issue Jul 11, 2023 · 3 comments
Closed
23 tasks
Tracked by #7125

Add missing icons in new Component Browser #7260

vitvakatu opened this issue Jul 11, 2023 · 3 comments
Assignees
@vitvakatu
Labels
d-easy Difficulty: little prior knowledge required p-high Should be completed in the next sprint

Comments

@vitvakatu
Copy link
Contributor

vitvakatu commented Jul 11, 2023 •
edited
Loading

CB

  • Left/right arrows for breadcrumbs
Screenshot 2023-07-12 at 12 35 27
  • Local scope (modified)
  • Command key
  • Unstable
  • Right-side Panel
Screenshot 2023-07-12 at 12 42 18
  • Date and time (modified)
Screenshot 2023-07-12 at 12 44 05
  • Calendar
Screenshot 2023-07-12 at 12 44 38
  • Array new
Screenshot 2023-07-12 at 12 45 54
  • ChatGPT
Screenshot 2023-07-12 at 12 46 18
  • Google
Screenshot 2023-07-12 at 12 46 20
  • Cloud From
Screenshot 2023-07-12 at 12 46 23
  • Convert (modified)
Screenshot 2023-07-12 at 12 53 39

Edited node

  • Enso logo
Screenshot 2023-07-12 at 12 43 25

Top Bar

(low priority)

  • Workflow Play
Screenshot 2023-07-12 at 12 38 30
  • Link
  • Graph editor
Screenshot 2023-07-12 at 12 54 00

Node Action Bar

  • Lock (modified)
  • Make node def local copy
  • Enter node
  • Docs
  • Eye (modified)
  • Expanded node
  • Skip (modified)
Screenshot 2023-07-12 at 12 49 00
@vitvakatu vitvakatu mentioned this issue Jul 11, 2023
Closed
@vitvakatu vitvakatu self-assigned this Jul 11, 2023
@vitvakatu vitvakatu added d-easy Difficulty: little prior knowledge required p-high Should be completed in the next sprint g-component-browser labels Jul 11, 2023
@vitvakatu vitvakatu moved this from ❓New to 🔧 Implementation in Issues Board Jul 11, 2023
@enso-bot
Copy link

enso-bot bot commented Jul 13, 2023

Ilya Bogdanov reports a new STANDUP for yesterday (2023-07-12):

Progress: Made a list of additional icons to make. Got distracted by urgent bug fixes. Spent some time bisecting the issue with missing node names and fixed the issue with error visualization position. Addressed review comments in PR with the new top bar. It should be finished by 2023-07-14.

@vitvakatu vitvakatu mentioned this issue Jul 14, 2023
Merged
5 tasks
@enso-bot
Copy link

enso-bot bot commented Jul 14, 2023

Ilya Bogdanov reports a new STANDUP for yesterday (2023-07-13):

Progress: Implemented the new icons for the CB. It should be finished by 2023-07-14.

@enso-bot
Copy link

enso-bot bot commented Jul 15, 2023

Ilya Bogdanov reports a new STANDUP for yesterday (2023-07-14):

Progress: Implemented a few additional icons, opened a PR. It should be finished by 2023-07-14.

@farmaazon farmaazon moved this from 🔧 Implementation to 👁️ Code review in Issues Board Jul 17, 2023
@farmaazon farmaazon moved this from 👁️ Code review to 🟢 Accepted in Issues Board Jul 18, 2023
mergify bot pushed a commit that referenced this issue Jul 18, 2023
@vitvakatu
New icons, part 1 (#7296)
f23c506 
Partially addresses #7260

A few new icons were added, and a few older ones were modified to match the new design.

This set of icons should be enough to cover our needs before the release.

- Compass icon for visualizations
- Unstable
- Command key
- Right side panel
- Array.new
- Local scope icon modified
- Clock icon modified
- Calendar
- Expand from the node's action bar
- Eye from action bar modified

Screenshots:
<img width="159" alt="Screenshot 2023-07-14 at 17 08 29" src="https://github.com/enso-org/enso/assets/6566674/286f2c1c-f5c1-4b56-a75a-7abcad191c51">
<img width="404" alt="Screenshot 2023-07-14 at 17 08 12" src="https://github.com/enso-org/enso/assets/6566674/e3f27e47-04ef-4bdd-9bb0-126936ccb27d">
<img width="1511" alt="Screenshot 2023-07-14 at 17 08 00" src="https://github.com/enso-org/enso/assets/6566674/307ac334-a423-46d6-b614-47cf1295ddd0">
<img width="728" alt="Screenshot 2023-07-14 at 17 08 05" src="https://github.com/enso-org/enso/assets/6566674/e63a4327-d640-4904-989b-ad1f0e83e497">

# Important Notes
No visual changes to the IDE itself, but I swapped the definitions of `HalfPlane` and `BottomHalfPlane` - now they reflect their names.
@farmaazon farmaazon moved this from 🟢 Accepted to 🗄️ Archived in Issues Board Jul 25, 2023
@github-project-automation github-project-automation bot moved this from 🗄️ Archived to 🟢 Accepted in Issues Board Nov 27, 2023
@farmaazon farmaazon moved this from 🟢 Accepted to 🗄️ Archived in Issues Board Nov 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vitvakatu vitvakatu

Labels
d-easy Difficulty: little prior knowledge required p-high Should be completed in the next sprint
Projects
Issues Board
Archived in project
Milestone
No milestone
Development

No branches or pull requests
2 participants
@farmaazon @vitvakatu