-
Notifications
You must be signed in to change notification settings - Fork 324
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Table.delete_rows
function allowing deleting rows in a database table.
#7238
Comments
Aim to review on Tuesday 11th |
Table.delete_rows
function allowing deleting rows in a database table.
Do we feel that a "filter_rows" where we produce effectively the result but in a query state is useful?
|
Radosław Waśko reports a new STANDUP for yesterday (2023-08-29): Progress: Adding new APIs for delete_rows. Clarifying spec and writing docs. Lots of meetings. Drafting a doc on an MVP for library sharing. It should be finished by 2023-09-01. Next Day: Next day I will be working on the same task. Finish the libraries doc. Update update_rows API. Write tests for delete_rows. |
Radosław Waśko reports a new STANDUP for today (2023-08-30): Progress: Posted the libraries "roadmap" doc. Updated the update_rows API - I think the new shape reads much better indeed. Written (I think quite comprehensive set of) tests for delete_rows. It should be finished by 2023-09-01. Next Day: Next day I will be working on the same task. Implement delete_rows |
Radosław Waśko reports a new STANDUP for yesterday (2023-08-31): Progress: Finished the delete_rows implementation - PR ready for review. Fixing the pending library resolution PR - some errors that I have overlooked earlier. Discussions on Data.post etc. It should be finished by 2023-09-01. Next Day: Next day I will be working on the #7354 task. Ensure the libraries resolution PR gets merged. Start next task - fixing small defects I found earlier. |
- Closes #7238 - Aligns `update_database_table` to a more consistent and clearer API - `update_rows`. - Adds a `truncate_table` helper function, to pair up with `drop_table`. Both are `PRIVATE` for now. - Adds tests for NULLs in keys in `update_rows` and `delete_rows`. - The behaviour is sometimes unexpected, so instead these fail with `Null_Values_In_Key_Columns`. - Adds a workaround for oracle/graal#7359 - Adds a workaround for a related bug where a stack frame has no name (its `rootNode.getName() == null`). - I could not track down this bug to provide a neat repro.
For example,
my_students.delete_rows (student_leaving_table) ["first_name", "last_name"]
returning number of rows (e.g. 31).Additionally, we should add a function is to delete all rows.
Connection.truncate_table target_table:Table -> Integer
returning the row count of deleted.Similar to
drop_table
.Additionally, flip
update_database_table
to be consistent:The text was updated successfully, but these errors were encountered: