Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CB labels to new design #7201

Closed
Tracked by #7125
farmaazon opened this issue Jul 4, 2023 · 0 comments · Fixed by #7327
Closed
Tracked by #7125

Update CB labels to new design #7201

farmaazon opened this issue Jul 4, 2023 · 0 comments · Fixed by #7327
Assignees
Labels
d-easy Difficulty: little prior knowledge required p-high Should be completed in the next sprint

Comments

@farmaazon
Copy link
Contributor

farmaazon commented Jul 4, 2023

As described in the new design

@github-project-automation github-project-automation bot moved this to ❓New in Issues Board Jul 4, 2023
@farmaazon farmaazon self-assigned this Jul 4, 2023
@farmaazon farmaazon added s-info-needed Status: more information needed from submitter d-easy Difficulty: little prior knowledge required p-high Should be completed in the next sprint g-component-browser labels Jul 4, 2023
@farmaazon farmaazon removed the s-info-needed Status: more information needed from submitter label Jul 19, 2023
@farmaazon farmaazon mentioned this issue Jul 19, 2023
5 tasks
@farmaazon farmaazon moved this from ❓New to 📤 Backlog in Issues Board Jul 19, 2023
@farmaazon farmaazon moved this from 📤 Backlog to 👁️ Code review in Issues Board Jul 19, 2023
@farmaazon farmaazon moved this from 👁️ Code review to 🌟 Q/A review in Issues Board Jul 20, 2023
mwu-tow pushed a commit that referenced this issue Jul 21, 2023
Fixes #7198 
Fixes #7318 

https://github.com/enso-org/enso/assets/3919101/4aead1e2-de01-4b6e-aa12-403af0b3c677

This PR changes the way components are kept in the controllers to allow mixing different groups when filtering. On this occasion, the code was greatly simplified:
* Instead of identifying entries by section, group and entry ID we have just a single EntryId representing position on the list. This way the view was simplified.
* Removed support for headers in Component Grid (but the Grid View still has this feature).
* Removed remnants of the old searcher and "actions".

Also, this PR fixes #7201. I decided that the top modules will have full path (namespace, library and module name), so they will be displayed as `Standard.Base.Data` instead of just `Data` (so it's clear we're browsing part of the standard library.

### Important Notes

The searcher's breadcrumbs controller is in not very nice state, but it will be revised anyway, as the breadcrumbs will be synchronized with documentation panel in the new design.
@github-project-automation github-project-automation bot moved this from 🌟 Q/A review to 🟢 Accepted in Issues Board Jul 21, 2023
@farmaazon farmaazon moved this from 🟢 Accepted to 🗄️ Archived in Issues Board Jul 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
d-easy Difficulty: little prior knowledge required p-high Should be completed in the next sprint
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant