Project created with a new nightly package is requesting an outdated engine #6560
Closed
1 of 2 tasks
Assignees
Labels
Comments
sylwiabr
added
--regression
|
I don't believe this is a regression. It has been like that for a while if not from the inception of that version check. |
|
The nightly package from yesterday does not have this issue so it is a regression. It is like that for dev builds where you have dev engine version but for nightlies it was fixed. |
mergify bot
pushed a commit
that referenced
this issue
May 8, 2023
This PR fixes #6560. The fix has a few elements: 1) Bumps the Engine requirement to the latest release, namely `2023.1.1`. 2) Changed the logic of checking whether a given version matches the requirement. Previously, we relied on `VersionReq` from `semver` crate which did not behave intuitively when the required version had a prerelease suffix. Now we rely directly on Semantic Versioning rules of precedence. 3) Code cleanups, including deduplicating 3 copies of the version-checking code, and moving some tests to more sensible places.
github-project-automation
bot
moved this from 👁️ Code review
to 🟢 Accepted
in Issues Board
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Discord username
No response
What type of issue is this?
Permanent – Occurring repeatably
Is this issue blocking you from using Enso?
Is this a regression?
What issue are you facing?
IDE is reporting unsupported Engine version for a project just created with newest nightly.
Expected behaviour
No warning - I have newer version then the one required
How we can reproduce it?
No response
Screenshots or screencasts
Enso Version
nightly 04.05
Browser or standalone distribution
Standalone distribution
Browser Version or standalone distribution
standalone
Operating System
MacOS
Operating System Version
No response
Hardware you are using
No response
The text was updated successfully, but these errors were encountered: