Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Range.Between not working with Dates #6543

Closed
2 tasks
kazcw opened this issue May 4, 2023 · 3 comments · Fixed by #6621
Closed
2 tasks

Range.Between not working with Dates #6543

kazcw opened this issue May 4, 2023 · 3 comments · Fixed by #6621
Assignees
Labels
-libs Libraries: New libraries to be implemented x-new-feature Type: new feature request

Comments

@kazcw
Copy link
Contributor

kazcw commented May 4, 2023

Discord username

No response

What type of issue is this?

Permanent – Occurring repeatably

Is this issue blocking you from using Enso?

  • Yes, I can't use Enso because of this issue.

Is this a regression?

  • Yes, previous version of Enso did not have this issue.

What issue are you facing?

I tried to use Range.Between to produce a sequence of Date values, but got an error. See bottom left:
image

Both inputs are Date objects; I don't know where the 0 mentioned in the error is coming from.

Expected behaviour

Range.Between should produce a range of dates.

How we can reproduce it?

No response

Screenshots or screencasts

No response

Enso Version

current develop (bb8f910)

Browser or standalone distribution

Standalone distribution

Browser Version or standalone distribution

standalone

Operating System

Linux

Operating System Version

No response

Hardware you are using

No response

@kazcw kazcw added --bug Type: bug triage labels May 4, 2023
@github-project-automation github-project-automation bot moved this to ❓New in Issues Board May 4, 2023
@jdunkerley jdunkerley added x-new-feature Type: new feature request -libs Libraries: New libraries to be implemented and removed --bug Type: bug triage labels May 4, 2023
@jdunkerley jdunkerley self-assigned this May 4, 2023
@jdunkerley
Copy link
Member

Libs will have a look into how best to expand the Date support to allow this.

@jdunkerley jdunkerley assigned radeusgd and unassigned jdunkerley May 9, 2023
@jdunkerley jdunkerley moved this from ❓New to 📤 Backlog in Issues Board May 9, 2023
@jdunkerley jdunkerley added this to the Design Partners milestone May 9, 2023
@radeusgd radeusgd moved this from 📤 Backlog to 🔧 Implementation in Issues Board May 9, 2023
@enso-bot
Copy link

enso-bot bot commented May 9, 2023

Radosław Waśko reports a new STANDUP for today (2023-05-09):

Progress: Implemented basic operations for Date_Range with a brute force algorithm. It should be finished by 2023-05-11.

Next Day: Next day I will be working on the same task. Add other missing operations. Better tests to ensure no infinite loops (n>1 cycles?). Add heuristics for more efficient computation of simple steps.

@radeusgd radeusgd mentioned this issue May 9, 2023
5 tasks
@enso-bot
Copy link

enso-bot bot commented May 10, 2023

Radosław Waśko reports a new STANDUP for today (2023-05-10):

Progress: Figuring out wild edge cases. Decided to only handle non-negative steps, as mixed sign steps were a huge pain. Implemented 2 O(1) heuristics that avoid an O(N) computation for simpler cases. Added lots of tests to ensure the heuristics work correctly. Prepared the PR. Started small tweaks on range widgets. It should be finished by 2023-05-11.

Next Day: Next day I will be working on the #6410 task. Continue widget related tasks. Possibly start Date parsing? We'll see what's needed.

@mergify mergify bot closed this as completed in #6621 May 11, 2023
mergify bot pushed a commit that referenced this issue May 11, 2023
@github-project-automation github-project-automation bot moved this from 🔧 Implementation to 🟢 Accepted in Issues Board May 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
-libs Libraries: New libraries to be implemented x-new-feature Type: new feature request
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants