Improve inlining of <| on GraalVM CE

[JaroslavTulach]

#6384 improved the speed of cascade of <| functions on GraalVM EE only. However we'd like to improve it for CE as well. Let's address that as a new issue.

The goal is to run:

sbt> runtime/benchOnly ifBench6

on GraalVM CE and make sure ifBench6 and ifBench6In are similarly fast.

[JaroslavTulach]

--- a/engine/runtime/src/main/java/org/enso/interpreter/node/expression/builtin/function/ApplicationOperator.java
+++ b/engine/runtime/src/main/java/org/enso/interpreter/node/expression/builtin/function/ApplicationOperator.java
@@ -25,7 +25,7 @@
     invokeCallableNode.setTailStatus(BaseNode.TailStatus.TAIL_DIRECT);
   }
 
-  Object execute(VirtualFrame frame, State state, Object self, @Suspend Object argument) {
-    return invokeCallableNode.execute(self, frame, state, new Object[] {argument});
+  Object execute(State state, Object self, @Suspend Object argument) {
+    return invokeCallableNode.execute(self, null, state, new Object[] {argument});
   }
 }

this change is known to speed the benchmark up. I am just not sure whether it is correct from functional perspective. But sbt runtime/test and test/Tests tests run without any problems. CCing @kustosz

[enso-bot]

Jaroslav Tulach reports a new STANDUP for yesterday (2023-04-26):

Progress: - @BuiltinMethod.needsFrame: #6442

• Fixing Debug.eval & <|: Introducing @BuiltinMethod.inlineable and InlineableNode #6442
• Speeding <| on GraalVM CE: Introducing @BuiltinMethod.inlineable and InlineableNode #6442
• multi-line if_then_else Investigation: Support multi-line if-then-else #6408 (comment)
• meetings, reviews It should be finished by 2023-05-02.

Next Day: Polish needsFrame, process backlog

[enso-bot]

Jaroslav Tulach reports a new STANDUP for yesterday (2023-04-27):

Progress: - Cleaning PR-6442 up: Rewriting to not subclass the DirectCallNode

• InlineableNode: 9b4a466
• running benchmarks: Introducing @BuiltinMethod.inlineable and InlineableNode #6442 (comment)
• testing: https://github.com/enso-org/enso/pull/6442/files#r1178771306
• if_then variable redefinition: Broken redefinition of variable inside if-then expression #6211 (comment)
• evaluation of Erroring with No_Such_Method.Error without any details #6451
• self profile to the rescue: New project initialization times out on "get host name" in vcs/init request #6447 (comment) It should be finished by 2023-05-02.

Next Day: Investigate 160% slowdown in one of the benchmarks

GitHub

Introducing @BuiltinMethod.needsFrame and InlineableNode by JaroslavTulach · Pull Request #6442 · enso-org/enso

Pull Request Description Fixes #6416 by introducing InlineableNode. It runs fast even on GraalVM CE, fixes (forever broken) Debug.eval with <| and removes discouraged subclassing of DirectCallNo...

[enso-bot]

Jaroslav Tulach reports a new STANDUP for today (2023-04-28):

Progress: - Fix for #6416 has been integrated #6442

• proposing Pavel as code owner: Welcome Pavel to engine team #6462
• discussing Type.to_text shall invoke instance method #6300 & follow up: Equality on types with Any as LHS does not work #5612
• ctx.close(): More reliable shutdown of the EnsoContext to save resources #6468
• Exception at the end of execution discussion: Exception from ResourceManager at end of execution #6472 (comment)
• Meta.meta Any . methods problem: Meta.meta Any . methods doesn't work #6473 It should be finished by 2023-05-02.

Next Day: Bugfixing