Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ctrl+r is resetting the project to the default project template #6377

Closed
sylwiabr opened this issue Apr 21, 2023 · 10 comments · Fixed by #6620
Closed

Ctrl+r is resetting the project to the default project template #6377

sylwiabr opened this issue Apr 21, 2023 · 10 comments · Fixed by #6620
Assignees
Labels
--bug Type: bug d-easy Difficulty: little prior knowledge required p-medium Should be completed in the next few sprints

Comments

@sylwiabr
Copy link
Member

sylwiabr commented Apr 21, 2023

Pressing Ctrl+r in IDE is removing the project content and leaving just the default node.

package from 21.04.2023 on MacOS and Windows

@jdunkerley
Copy link
Member

As we have no way to revert to previous versions this caused a loss of a workflow.

@jdunkerley
Copy link
Member

This appears to be a "revert to saved state". This must ask the user to confirm before performing the action.

@vitvakatu vitvakatu removed the --regression Important: regression label Apr 21, 2023
@vitvakatu
Copy link
Contributor

This is not a regression, the shortcut has been there for a very long time.
@sylwiabr do you have a vision of how we can fix it? Implementing confirmation would take a lot of time.

@sylwiabr
Copy link
Member Author

Somehow before the ctrl+r was refreshing IDE and getting us to the Welcome Screen in a previous versions (see the nightly package from 20.4.2023). I would suggest changing shortcut to something less popular than ctrl+r so user will not accidentally perform the action and loose the work. What do you think @wdanilo?

@jdunkerley
Copy link
Member

I think the typescript based shortcuts were covering it up so Ctrl-R was causing an electron refresh (now on Ctrl-Alt-Shit-R).

@wdanilo
Copy link
Member

wdanilo commented Apr 24, 2023

If ctrl-shift-r is refreshing electron now, what does ctrl-r do now? There has to be some logic there if we observe this behavior. I fully agree with Sylwia that any shortcut that makes the user lose the workflow is bad and we need to fix it.

@jdunkerley
Copy link
Member

Ctrl-R resets the project back to the last checkpoint (which I think Ctrl-S stores).

@wdanilo
Copy link
Member

wdanilo commented Apr 24, 2023

Ok, then I believe we have the following things to do here:

  1. refreshing electron should be ctrl-alt-r (as with all our debug shortcuts, it should start with ctrl-alt, as it is a developer-shortcut, not user-one).
  2. We should create a popup asking if you want to get back to last saved snapshot. Until this is done, we can change the shortcut to ctrl-shift-r or something like that so it's not so easy to trigger. Of course, longer term, this should be done this way that when you switch to last saved checkpoint, a new checkpoint should be created before the switch which would allow you to switch back, but this would also require a view of list of checkpoints and managing a tree of checkpoints (not a flat list of them).

@farmaazon
Copy link
Contributor

Let's put only the shortcut changes to scope of this issue, and make new issues for other ideas (asking user, and then full change-tree view).

@farmaazon farmaazon added d-easy Difficulty: little prior knowledge required p-medium Should be completed in the next few sprints labels May 2, 2023
@farmaazon farmaazon moved this from ❓New to 📤 Backlog in Issues Board May 2, 2023
@farmaazon farmaazon assigned Procrat and unassigned farmaazon May 2, 2023
@Procrat Procrat moved this from 📤 Backlog to 🔧 Implementation in Issues Board May 5, 2023
Procrat added a commit that referenced this issue May 9, 2023
Procrat added a commit that referenced this issue May 9, 2023
@Procrat Procrat moved this from 🔧 Implementation to 👁️ Code review in Issues Board May 9, 2023
@Procrat Procrat moved this from 👁️ Code review to 🌟 Q/A review in Issues Board May 10, 2023
@Procrat
Copy link
Contributor

Procrat commented May 10, 2023

I've changed the shortcut in #6620 and created two issues for the other ideas:

@mergify mergify bot closed this as completed in #6620 May 10, 2023
mergify bot pushed a commit that referenced this issue May 10, 2023
Fixes #6377: The fact that `ctrl-r` was restoring the project to potentially the initial state was confusing. This PR changes that shortcut to `ctrl-shift-r`, as discussed in #6377.

Note that:
- `ctrl-shift-r` was already taken by the re-execution shortcut, so that got the `ctrl-alt` modifiers instead, along with the interruption shortcut for consistency.
- `ctrl-alt-shift-r` was already taken by a shortcut to refresh the whole Electron app, so that wasn't available.
@github-project-automation github-project-automation bot moved this from 🌟 Q/A review to 🟢 Accepted in Issues Board May 10, 2023
Procrat added a commit that referenced this issue May 10, 2023
…ing-6287

* develop:
  Fix issues with missing sourcemaps (#6572)
  Fix asset delete; implement project delete and project rename (#6566)
  Fix #6377: Change ctrl-r shortcut (#6620)
  Add tests for Date.until, Date.next and Date.previous. (#6606)
  Improve `Non_Unique_Primary_Key` error, split file format detection into read/write, improve SQLite format detection (#6604)
  tokenize_to_columns or parse_to_columns results in a single column we shouldn't add the  1 (#6607)
  Fix node editing race condition (#6594)
  Add format to the in-memory Column (#6538)
  Fix dashboard issues (part 2) (#6511)
  Fix visualisation type selector artifacts rendered after node preview visualisation was closed. (#6575)
  Revert typescript CI Lint changes (#6602)
  Fix the Engine version check in GUI (#6570)
Procrat added a commit that referenced this issue May 10, 2023
* develop:
  Limit the number of reported warnings (#6577)
  Add COOP+COEP+CORP headers (#6597)
  Fix issues with missing sourcemaps (#6572)
  Fix asset delete; implement project delete and project rename (#6566)
  Fix #6377: Change ctrl-r shortcut (#6620)
@farmaazon farmaazon moved this from 🟢 Accepted to 🗄️ Archived in Issues Board May 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
--bug Type: bug d-easy Difficulty: little prior knowledge required p-medium Should be completed in the next few sprints
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

7 participants