Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Read-only mode for Views #6182

Closed
9 tasks done
Tracked by #5899
vitvakatu opened this issue Apr 3, 2023 · 2 comments · Fixed by #6342
Closed
9 tasks done
Tracked by #5899

Read-only mode for Views #6182

vitvakatu opened this issue Apr 3, 2023 · 2 comments · Fixed by #6342
Assignees
@vitvakatu
Labels
d-hard Difficulty: significant prior knowledge required p-high Should be completed in the next sprint
Milestone
Design Partners

Comments

@vitvakatu
Copy link
Contributor

vitvakatu commented Apr 3, 2023 •
edited
Loading

There are two approaches to introducing read-only mode in IDE:

  1. A more general one, add some read-only flag to display objects and propagate this property through the hierarchy.
  2. A more specific one, add conditional checks in all the necessary places and add FRP endpoints in particular components that need to support read-only mode.

This task is about the second approach.

The things that we should lock:

  • Project Name renaming (double clicking)
  • Nodes editing
  • Code Editor
  • Creating nodes
  • Removing nodes
  • Entering and leaving nodes
  • Connections between nodes
  • Buttons on nodes
  • Widgets on nodes

Acceptance Criteria

Check if everything above is not possible when the read-only mode is active.
@vitvakatu vitvakatu added d-hard Difficulty: significant prior knowledge required p-high Should be completed in the next sprint g-graph-editor labels Apr 3, 2023
@vitvakatu vitvakatu self-assigned this Apr 3, 2023
@github-project-automation github-project-automation bot moved this to ❓New in Issues Board Apr 3, 2023
@vitvakatu vitvakatu moved this from ❓New to 📤 Backlog in Issues Board Apr 3, 2023
@vitvakatu vitvakatu mentioned this issue Apr 3, 2023
Closed
@vitvakatu vitvakatu moved this from 📤 Backlog to 🔧 Implementation in Issues Board Apr 13, 2023
@sylwiabr sylwiabr added this to the Design Partners milestone Apr 17, 2023
@vitvakatu vitvakatu mentioned this issue Apr 18, 2023
Merged
14 tasks
@enso-bot
Copy link

enso-bot bot commented Apr 18, 2023

Ilya Bogdanov reports a new STANDUP for yesterday (2023-04-17):

Progress: Working on read-only mode. Finished the implementation for most components. Attended weekly demo. It should be finished by 2023-04-19.

Next Day: Next day I will be working on the same task. finish the task and open a PR

@enso-bot
Copy link

enso-bot bot commented Apr 18, 2023

Ilya Bogdanov reports a new STANDUP for today (2023-04-18):

Progress: Finished read-only mode support for project name, buttons on nodes, and widgets. Tested and created a PR. It should be finished by 2023-04-19.

Next Day: Next day I will be working on the #6228 task. starting to work on the next task

@vitvakatu vitvakatu moved this from 🔧 Implementation to 👁️ Code review in Issues Board Apr 19, 2023
@vitvakatu vitvakatu moved this from 👁️ Code review to 🌟 Q/A review in Issues Board Apr 19, 2023
mwu-tow pushed a commit that referenced this issue Apr 24, 2023
@vitvakatu
Forbid edits in read-only mode (#6342)
719bd8c 
Closes #6182 

Implements read-only mode for relevant components of the IDE.

- [x]  Project Name renaming
- [x]  Nodes editing
- [x]  Editing code in the code editor
- [x]  Creating nodes
- [x]  Removing nodes
- [x]  Entering and leaving nodes
- [x]  Creating, dropping, and changing connections between nodes
- [x]  Buttons on nodes (except for visualization toggle button)
- [x]  Widgets on nodes


https://user-images.githubusercontent.com/6566674/232824737-bdd6f676-b20d-4218-af7d-4373e00cbe3e.mp4
@github-project-automation github-project-automation bot moved this from 🌟 Q/A review to 🟢 Accepted in Issues Board Apr 24, 2023
@farmaazon farmaazon moved this from 🟢 Accepted to 🗄️ Archived in Issues Board May 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vitvakatu vitvakatu

Labels
d-hard Difficulty: significant prior knowledge required p-high Should be completed in the next sprint
Projects
Issues Board
Archived in project
Milestone
Design Partners
Development

Successfully merging a pull request may close this issue.

Forbid edits in read-only mode enso-org/enso
2 participants
@vitvakatu @sylwiabr