Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workflow-level Play button business-logic #6179

Closed
Tracked by #5899
vitvakatu opened this issue Apr 3, 2023 · 6 comments · Fixed by #6427
Closed
Tracked by #5899

Workflow-level Play button business-logic #6179

vitvakatu opened this issue Apr 3, 2023 · 6 comments · Fixed by #6427
Assignees
Labels
d-easy Difficulty: little prior knowledge required p-high Should be completed in the next sprint

Comments

@vitvakatu
Copy link
Contributor

The following actions must be implemented in controllers and connected to the Play button.

  1. A read-only flag must be added in controllers. If it is set, the user is not able to modify the project (not in scope)
  2. Mock communication with the engine when the Play button is pressed. For testing purposes, a new temporary shortcut can be added to "assume the execution has finished".
  3. When the Play button is pressed, it should:
    a. Enable read-only mode.
    b. Change the Play button icon to the spinner.
    c. Send a message to the engine to start execution with all contexts enabled.
  4. When the execution is finished (either the engine told us about it or the user pressed a special shortcut)
    a. Disable read-only mode.
    b. Change the Play button back to its original icon.

Acceptance Criteria

See the points above.

@vitvakatu vitvakatu added d-easy Difficulty: little prior knowledge required p-high Should be completed in the next sprint -gui labels Apr 3, 2023
@vitvakatu vitvakatu self-assigned this Apr 3, 2023
@github-project-automation github-project-automation bot moved this to ❓New in Issues Board Apr 3, 2023
@vitvakatu vitvakatu moved this from ❓New to 📤 Backlog in Issues Board Apr 3, 2023
@MichaelMauderer MichaelMauderer moved this from 📤 Backlog to 🔧 Implementation in Issues Board Apr 6, 2023
@enso-bot
Copy link

enso-bot bot commented Apr 6, 2023

Michael Mauderer reports a new STANDUP for today (2023-04-06):

Progress: Postponed draft PR to avoid necessary CI running (but branch is there). PR needs to await merge of previous PR which is awaiting re-reviews. Started working on new controller functionality for mock information passing from the play button. It should be finished by 2023-04-13.

Next Day: Next day I will be working on the #6179 task. Continue work on task.

@enso-bot
Copy link

enso-bot bot commented Apr 11, 2023

Michael Mauderer reports a new STANDUP for today (2023-04-11):

Progress: I was working on following up the QA issue found on #6130. Found the solution and provided a workaround. Day was plagued by some build script issues again (#6168 and #6091). It should be finished by 2023-04-13.

Next Day: Next day I will be working on the #6179 task. Continue work on the play icon.

@enso-bot
Copy link

enso-bot bot commented Apr 12, 2023

Michael Mauderer reports a new STANDUP for today (2023-04-12):

Progress: Created integration of the play button with the controller / LS API. Made good progress with mocking starting / ending execution. It should be finished tomorrow. It should be finished by 2023-04-13.

Next Day: Next day I will be working on the #6179 task. Finish implementation, clean up code and open draft PR.

@enso-bot
Copy link

enso-bot bot commented Apr 17, 2023

Michael Mauderer reports a new 🔴 DELAY for the provided date (2023-04-14):

Summary: There is 5 days delay in implementation of the Workflow-level Play button business-logic (#6179) task.
It will cause 0 days delay for the delivery of this weekly plan.

2 days weekend, 1 day off.

Delay Cause: Delayed due to late review on PR that comes before this, and wasm-pack text issue.

@enso-bot
Copy link

enso-bot bot commented Apr 17, 2023

Michael Mauderer reports a new STANDUP for the provided date (2023-04-14):

Progress: Finish implementation and code clean up. Awaiting merging of previous PRs which is blocked by a wasm-pack issue. It should be finished by 2023-04-18.

Next Day: Next day I will be working on the #6179 task. Investigate wasm-pack issue that is causing tests to not run.

@enso-bot
Copy link

enso-bot bot commented Apr 17, 2023

Michael Mauderer reports a new STANDUP for today (2023-04-17):

Progress: Investigated wasm-pack issue. Found it to be caused by large file size of wasm files generated for test. Solution is to increase opt level or stripping debug symbols. It should be finished by 2023-04-18.

Next Day: Next day I will be working on the #6179 task. Update ready to be reviewed and merged PRs.

@sylwiabr sylwiabr added this to the Design Partners milestone Apr 17, 2023
@MichaelMauderer MichaelMauderer moved this from 🔧 Implementation to 👁️ Code review in Issues Board Apr 21, 2023
@vitvakatu vitvakatu moved this from 👁️ Code review to 🌟 Q/A review in Issues Board Apr 27, 2023
@MichaelMauderer MichaelMauderer linked a pull request Apr 27, 2023 that will close this issue
5 tasks
@mergify mergify bot closed this as completed in #6427 Apr 27, 2023
@github-project-automation github-project-automation bot moved this from 🌟 Q/A review to 🟢 Accepted in Issues Board Apr 27, 2023
@farmaazon farmaazon moved this from 🟢 Accepted to 🗄️ Archived in Issues Board May 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
d-easy Difficulty: little prior knowledge required p-high Should be completed in the next sprint
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants