-
Notifications
You must be signed in to change notification settings - Fork 323
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Workflow-level Play button business-logic #6179
Comments
Michael Mauderer reports a new STANDUP for today (2023-04-06): Progress: Postponed draft PR to avoid necessary CI running (but branch is there). PR needs to await merge of previous PR which is awaiting re-reviews. Started working on new controller functionality for mock information passing from the play button. It should be finished by 2023-04-13. Next Day: Next day I will be working on the #6179 task. Continue work on task. |
Michael Mauderer reports a new STANDUP for today (2023-04-11): Progress: I was working on following up the QA issue found on #6130. Found the solution and provided a workaround. Day was plagued by some build script issues again (#6168 and #6091). It should be finished by 2023-04-13. Next Day: Next day I will be working on the #6179 task. Continue work on the play icon. |
Michael Mauderer reports a new STANDUP for today (2023-04-12): Progress: Created integration of the play button with the controller / LS API. Made good progress with mocking starting / ending execution. It should be finished tomorrow. It should be finished by 2023-04-13. Next Day: Next day I will be working on the #6179 task. Finish implementation, clean up code and open draft PR. |
Michael Mauderer reports a new 🔴 DELAY for the provided date (2023-04-14): Summary: There is 5 days delay in implementation of the Workflow-level Play button business-logic (#6179) task. 2 days weekend, 1 day off. Delay Cause: Delayed due to late review on PR that comes before this, and wasm-pack text issue. |
Michael Mauderer reports a new STANDUP for the provided date (2023-04-14): Progress: Finish implementation and code clean up. Awaiting merging of previous PRs which is blocked by a wasm-pack issue. It should be finished by 2023-04-18. Next Day: Next day I will be working on the #6179 task. Investigate wasm-pack issue that is causing tests to not run. |
Michael Mauderer reports a new STANDUP for today (2023-04-17): Progress: Investigated wasm-pack issue. Found it to be caused by large file size of wasm files generated for test. Solution is to increase opt level or stripping debug symbols. It should be finished by 2023-04-18. Next Day: Next day I will be working on the #6179 task. Update ready to be reviewed and merged PRs. |
The following actions must be implemented in controllers and connected to the Play button.
read-only
flag must be added in controllers. If it is set, the user is not able to modify the project (not in scope)a. Enable read-only mode.
b. Change the Play button icon to the spinner.
c. Send a message to the engine to start execution with all contexts enabled.
a. Disable read-only mode.
b. Change the Play button back to its original icon.
Acceptance Criteria
See the points above.
The text was updated successfully, but these errors were encountered: