Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hiding and showing Play button depending on the current execution mode #6177

Closed
Tracked by #5899
vitvakatu opened this issue Apr 3, 2023 · 3 comments · Fixed by #6252 or #6302
Closed
Tracked by #5899

Hiding and showing Play button depending on the current execution mode #6177

vitvakatu opened this issue Apr 3, 2023 · 3 comments · Fixed by #6252 or #6302
Assignees
Labels
d-easy Difficulty: little prior knowledge required p-high Should be completed in the next sprint x-new-feature Type: new feature request

Comments

@vitvakatu
Copy link
Contributor

vitvakatu commented Apr 3, 2023

The Play button should be visible only in a mode with one or more execution contexts disabled. It means the button must be hidden in live, but visible in design. This behavior can be hard coded.

Also, a second state for the Play icon must be added – a rotating spinner. This spinner would be displayed when the execution is in progress after pressing the button. The spinner should be animated on GPU similar to our blinking cursor.

Only visual changes for the button are in the scope of this task. For testing, new temporary shortcuts can be added to show/hide the button on demand and to enable/disable the spinner.

Acceptance Criteria

GIVEN an opened IDE
WHEN the current execution mode is `live`
THEN The Play button is not visible on the execution mode dropdown

WHEN the current execution mode is `design`
THEN The Play button is visible and can be clicked.

WHEN I press the button
THEN A rotating spinner is displayed instead of Play icon.
@vitvakatu vitvakatu added d-easy Difficulty: little prior knowledge required p-high Should be completed in the next sprint x-new-feature Type: new feature request -gui labels Apr 3, 2023
@vitvakatu vitvakatu self-assigned this Apr 3, 2023
@github-project-automation github-project-automation bot moved this to ❓New in Issues Board Apr 3, 2023
@vitvakatu vitvakatu moved this from ❓New to 📤 Backlog in Issues Board Apr 3, 2023
@vitvakatu vitvakatu assigned Procrat and unassigned vitvakatu Apr 3, 2023
@enso-bot
Copy link

enso-bot bot commented Apr 7, 2023

Stijn Seghers reports a new STANDUP for today (2023-04-07):

Progress: Started defining a spinner icon and abstracting away the play button area of the execution environment selector. It should be finished by 2023-04-14.

@Procrat Procrat moved this from 📤 Backlog to 🔧 Implementation in Issues Board Apr 7, 2023
@enso-bot
Copy link

enso-bot bot commented Apr 11, 2023

Stijn Seghers reports a new STANDUP for today (2023-04-11):

Progress: After a day of distractions, managed to abstract away the play button area of the execution environment selector. Actually showing/hiding the button is the final step. It should be finished by 2023-04-14.

@Procrat Procrat moved this from 🔧 Implementation to 👁️ Code review in Issues Board Apr 12, 2023
@enso-bot
Copy link

enso-bot bot commented Apr 12, 2023

Stijn Seghers reports a new STANDUP for today (2023-04-12):

Progress: Clicking the play button now turns it into a spinner. It also hides the play button when the active execution environment doesn't have any context disabled. Created a PR. It should be finished by 2023-04-14.

@Procrat Procrat linked a pull request Apr 13, 2023 that will close this issue
5 tasks
@Procrat Procrat moved this from 👁️ Code review to 🌟 Q/A review in Issues Board Apr 13, 2023
mergify bot pushed a commit that referenced this issue Apr 13, 2023
Closes #6177: Clicking the play button should show a spinner icon. The play button should only be visible on execution environments that have one or more execution contexts disabled.

https://user-images.githubusercontent.com/607786/231464097-8d6fafe4-1013-47d9-89e8-2a8e5d6d39a6.mp4

# Important Notes
There's a bug in the existing code that's exacerbated by this PR: the clickable area for the drop down menu is not directly placed on top of the text. Michael is fixing that in a [separate branch](https://github.com/enso-org/enso/tree/wip/MichaelMauderer/Ability_to_change_the_execution_environment_between_design_and_live_on_shortcut) (39ce6a2).
@Procrat Procrat moved this from 🌟 Q/A review to 🟢 Accepted in Issues Board Apr 14, 2023
@sylwiabr sylwiabr added this to the Design Partners milestone Apr 17, 2023
@farmaazon farmaazon moved this from 🟢 Accepted to 🗄️ Archived in Issues Board Apr 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
d-easy Difficulty: little prior knowledge required p-high Should be completed in the next sprint x-new-feature Type: new feature request
Projects
Archived in project
3 participants