-
Notifications
You must be signed in to change notification settings - Fork 323
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hiding and showing Play button depending on the current execution mode #6177
Comments
Stijn Seghers reports a new STANDUP for today (2023-04-07): Progress: Started defining a spinner icon and abstracting away the play button area of the execution environment selector. It should be finished by 2023-04-14. |
Stijn Seghers reports a new STANDUP for today (2023-04-11): Progress: After a day of distractions, managed to abstract away the play button area of the execution environment selector. Actually showing/hiding the button is the final step. It should be finished by 2023-04-14. |
Stijn Seghers reports a new STANDUP for today (2023-04-12): Progress: Clicking the play button now turns it into a spinner. It also hides the play button when the active execution environment doesn't have any context disabled. Created a PR. It should be finished by 2023-04-14. |
Closes #6177: Clicking the play button should show a spinner icon. The play button should only be visible on execution environments that have one or more execution contexts disabled. https://user-images.githubusercontent.com/607786/231464097-8d6fafe4-1013-47d9-89e8-2a8e5d6d39a6.mp4 # Important Notes There's a bug in the existing code that's exacerbated by this PR: the clickable area for the drop down menu is not directly placed on top of the text. Michael is fixing that in a [separate branch](https://github.com/enso-org/enso/tree/wip/MichaelMauderer/Ability_to_change_the_execution_environment_between_design_and_live_on_shortcut) (39ce6a2).
The Play button should be visible only in a mode with one or more execution contexts disabled. It means the button must be hidden in
live
, but visible indesign
. This behavior can be hard coded.Also, a second state for the Play icon must be added – a rotating spinner. This spinner would be displayed when the execution is in progress after pressing the button. The spinner should be animated on GPU similar to our blinking cursor.
Only visual changes for the button are in the scope of this task. For testing, new temporary shortcuts can be added to show/hide the button on demand and to enable/disable the spinner.
Acceptance Criteria
The text was updated successfully, but these errors were encountered: