Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Table/Column.cast #6112

Closed
3 of 7 tasks
radeusgd opened this issue Mar 28, 2023 · 4 comments · Fixed by #6711
Closed
3 of 7 tasks

Implement Table/Column.cast #6112

radeusgd opened this issue Mar 28, 2023 · 4 comments · Fixed by #6711
Assignees
Labels
-libs Libraries: New libraries to be implemented l-table-column-datatypes x-new-feature Type: new feature request
Milestone

Comments

@radeusgd
Copy link
Member

radeusgd commented Mar 28, 2023

Known in the specification as set_value_type.

@radeusgd radeusgd self-assigned this Mar 28, 2023
@radeusgd radeusgd added -libs Libraries: New libraries to be implemented l-table-column-datatypes x-new-feature Type: new feature request labels Mar 28, 2023
@jdunkerley jdunkerley moved this from ❓New to 📤 Backlog in Issues Board Mar 28, 2023
@jdunkerley jdunkerley added this to the Beta Release milestone Mar 28, 2023
@radeusgd radeusgd moved this from 📤 Backlog to 🔧 Implementation in Issues Board May 15, 2023
@enso-bot
Copy link

enso-bot bot commented May 16, 2023

Radosław Waśko reports a new STANDUP for yesterday (2023-05-15):

Progress: Added test cases for cast, some design on how it could play with parse. Implementing common paths. Started implementing casting in-memory. It should be finished by 2023-05-18.

Next Day: Next day I will be working on the same task. Add remaining in-memory casts. Testing.

@enso-bot
Copy link

enso-bot bot commented May 16, 2023

Radosław Waśko reports a new STANDUP for today (2023-05-16):

Progress: Implemented rest of in-memory casting logic (for now). Fixed issues ensuring (almost) all tests will be passing. Discussion about imports and encapsulation. Did today's bookclub (still need to catchup with Friday's). Got a draft PR up. It should be finished by 2023-05-18.

Next Day: Next day I will be working on the same task. Implement Lossy_Conversion facilities for the float->int conversion case in in-memory. Get the full PR ready. Catch up with bookclubs. Maybe start add_row_number.

@enso-bot
Copy link

enso-bot bot commented May 17, 2023

Radosław Waśko reports a new STANDUP for today (2023-05-17):

Progress: Added the Lossy_Conversion warning. PR ready for review. Working on adding simple parse scenarios to Database bakcend replacing disabled cast paths. Basically got it done but got stuck at a weird warning propagation bug - will need to investigate. Caught up with bookclubs. It should be finished by 2023-05-18.

Next Day: Next day I will be working on the same task. Get the PR merged. Investigate the warnings bug - report it and find a workaround/fix. Create a PR for the parse improvements. Start work on add_row_numbers

@mergify mergify bot closed this as completed in #6711 May 19, 2023
mergify bot pushed a commit that referenced this issue May 19, 2023
@github-project-automation github-project-automation bot moved this from 🔧 Implementation to 🟢 Accepted in Issues Board May 19, 2023
@enso-bot
Copy link

enso-bot bot commented May 19, 2023

Radosław Waśko reports a new STANDUP for yesterday (2023-05-18):

Progress: Applying suggestions on the PR. Got the PR merged. Found out the losing warnings bug and reported a repro. It should be finished by 2023-05-18.

Next Day: Next day I will be working on the #6410 task. Add workarounds for the bug in the parse PR. Prepare it to be merged. Start work on Mixed->? casts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
-libs Libraries: New libraries to be implemented l-table-column-datatypes x-new-feature Type: new feature request
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants